Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force post-process exit with process.exit #724

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

smorimoto
Copy link
Member

Since the release a few weeks ago, the action runner apparently no longer properly catches the exit of the post process. I don't know the root cause, but we can force exit the post process with process.exit.

@smorimoto smorimoto added bug Something isn't working upstream labels Nov 21, 2023
@smorimoto
Copy link
Member Author

@smorimoto
Copy link
Member Author

You can see the comparison here. It took more than 2 minutes, but it takes less than 5 seconds after this change.
https://github.com/ocaml/setup-ocaml/actions/runs/6944592357/job/18892081452
https://github.com/ocaml/setup-ocaml/actions/runs/6944324880/job/18891249108

@smorimoto smorimoto merged commit b93bf29 into master Nov 21, 2023
13 checks passed
@smorimoto smorimoto deleted the fix-post-process branch November 21, 2023 14:06
@smorimoto smorimoto linked an issue Nov 21, 2023 that may be closed by this pull request
@smorimoto smorimoto mentioned this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance issues
1 participant