Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koa: support async local storage attribute #68108

Conversation

fatwong
Copy link
Contributor

@fatwong fatwong commented Jan 5, 2024

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <feat: support asyncLocalStorage koajs/koa#1721>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 5, 2024

@fatwong Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 68108,
  "author": "fatwong",
  "headCommitOid": "a587556738a82c0f0b65ce1ec21349513d6e0808",
  "mergeBaseOid": "b34376d6c87b412a82565d3dbd4ec8fddce9e490",
  "lastPushDate": "2024-01-05T04:22:52.000Z",
  "lastActivityDate": "2024-01-09T10:07:38.000Z",
  "maintainerBlessed": "Waiting for Code Reviews",
  "mergeOfferDate": "2024-01-09T01:03:25.000Z",
  "mergeRequestDate": "2024-01-09T10:07:38.000Z",
  "mergeRequestUser": "fatwong",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "koa",
      "kind": "edit",
      "files": [
        {
          "path": "types/koa/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/koa/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/koa/test/constructor.ts",
          "kind": "test"
        },
        {
          "path": "types/koa/test/index.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "jkeylu",
        "brikou",
        "harryparkdotio",
        "chatoo2412",
        "tellnes",
        "pkuczynski",
        "vnoder"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "pkuczynski",
      "date": "2024-01-05T06:56:42.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1878104536,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @jkeylu @brikou @harryparkdotio @chatoo2412 @tellnes @pkuczynski @vnoder — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 5, 2024

@fatwong Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 68108,
  "author": "fatwong",
  "headCommitOid": "a587556738a82c0f0b65ce1ec21349513d6e0808",
  "mergeBaseOid": "b34376d6c87b412a82565d3dbd4ec8fddce9e490",
  "lastPushDate": "2024-01-05T04:22:52.000Z",
  "lastActivityDate": "2024-01-09T10:07:38.000Z",
  "maintainerBlessed": "Waiting for Code Reviews",
  "mergeOfferDate": "2024-01-09T01:03:25.000Z",
  "mergeRequestDate": "2024-01-09T10:07:38.000Z",
  "mergeRequestUser": "fatwong",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "koa",
      "kind": "edit",
      "files": [
        {
          "path": "types/koa/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/koa/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/koa/test/constructor.ts",
          "kind": "test"
        },
        {
          "path": "types/koa/test/index.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "jkeylu",
        "brikou",
        "harryparkdotio",
        "chatoo2412",
        "tellnes",
        "pkuczynski",
        "vnoder"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "pkuczynski",
      "date": "2024-01-05T06:56:42.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1878104536,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Jan 5, 2024
@typescript-bot typescript-bot added the Self Merge This PR can now be self-merged by the PR author or an owner label Jan 9, 2024
@typescript-bot
Copy link
Contributor

@fatwong: Everything looks good here. I am ready to merge this PR (at a587556) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@jkeylu, @brikou, @harryparkdotio, @chatoo2412, @tellnes, @pkuczynski, @vnoder: you can do this too.)

@fatwong
Copy link
Contributor Author

fatwong commented Jan 9, 2024

Ready to merge

@typescript-bot typescript-bot merged commit 266407a into DefinitelyTyped:master Jan 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants