Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support asyncLocalStorage #1721

Merged
merged 1 commit into from
Dec 6, 2022
Merged

feat: support asyncLocalStorage #1721

merged 1 commit into from
Dec 6, 2022

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Dec 6, 2022

pick from #1455
pick from #1718

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Base: 99.60% // Head: 99.61% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a30f869) compared to base (d36e5f7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             v2.x    #1721   +/-   ##
=======================================
  Coverage   99.60%   99.61%           
=======================================
  Files           5        5           
  Lines         508      520   +12     
  Branches      143      145    +2     
=======================================
+ Hits          506      518   +12     
  Misses          2        2           
Impacted Files Coverage Δ
lib/application.js 98.47% <100.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fengmk2
Copy link
Member Author

fengmk2 commented Dec 6, 2022

> make -C benchmarks


  1 middleware 
  35897.62

  5 middleware 
  35746.13

  10 middleware 
  35301.83

  15 middleware 
  35013.68

  20 middleware 
  34659.48

  30 middleware 
  34392.32

  50 middleware 
  32751.03

  100 middleware 
  32041.21

  1 async middleware 
  34012.71

  5 async middleware 
  35437.67

  10 async middleware 
  34759.20

  15 async middleware 
  33877.35

  20 async middleware 
  32487.66

  30 async middleware 
  31547.37

  50 async middleware 
  26018.91

  100 async middleware 
  25044.55

  1 async middleware with asyncLocalStorage
  25236.60

  5 async middleware with asyncLocalStorage
  28190.28

  10 async middleware with asyncLocalStorage
  27993.33

  15 async middleware with asyncLocalStorage
  28634.36

  20 async middleware with asyncLocalStorage
  25402.22

  30 async middleware with asyncLocalStorage
  25973.56

  50 async middleware with asyncLocalStorage
  22281.10

  100 async middleware with asyncLocalStorage
  16808.98

@fengmk2
Copy link
Member Author

fengmk2 commented Dec 6, 2022

@fengmk2 fengmk2 merged commit a293122 into v2.x Dec 6, 2022
@fengmk2 fengmk2 deleted the pick-asyncLocalStorage branch December 6, 2022 11:32
@fengmk2
Copy link
Member Author

fengmk2 commented Dec 6, 2022

2.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant