snipe qol prs from upstream #2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This duplicates other methods of discarding chemicals, including the drain conventionally given to chemistry labs. Any problems it solves are miniscule compared to the severe UI error that is having a destructive action without confirmation attached to a mode, the most common source of user error.
* Working on dehydrate recipes to renew animal cubes * Added remaining cube dehydration recipes * Add OnExamine to RehydratableSystem.cs, need to add functionality to check total volume vs current volume to determine if 'soaked' text needs to be displayed * Added logic to append text to the description when the wrong reagent has been added to a compressed animal cube * Re-adding deleted summary * Update default SolutionName to be correct * Remove cube recipes to prevent infinite nutrient generation * Add OnMicrowaved event to RehydratableSystem.cs in order to clear solution of cube when microwaved. CURRENT ERROR REQUIRES REFACTOR OF MICROWAVECOMPONENT * Subscribe to microwave event * Refactor of MicrowaveComponent.cs to be in shared folder, accessible to RehydratableSystem.cs. Updated imports * Modify cube to only dehydrate in microwave when cooked for at least 5 seconds
…ect slots (#31902) * ReflectComponentLogicFix Added bool InRightPlace and updated relevant system * Using SlotFlags
* add NoFriendlyFire * make zombies use NoFriendlyFire * no friendly fire for dragon * let dragon kill naughty fish and validhunting syndies
* add EntityName at the bottom of LogProbe * add button to print logprobe logs
* ai-glass * weh to protect against bad grammar * transmutation into diagnostic hud
github-actions
bot
added
S: Needs Review
Changes: YML
Lyndomen
previously approved these changes
Jan 4, 2025
|
Dunno if it would be too much trouble but any chance we can get space-wizards/space-station-14#29742 in this list? |
|
i wanted too but 18 files changed 💀 |
deltanedas
force-pushed
the
upstream-sniping-ops
branch
from
ab7a263 to
9444e20
Compare
2 tasks
|
@deltanedas Thank you for showing my oldest PR some love! Hope it serves DeltaV well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
snipe random qol and fixes prs:
Why / Balance
theyre all good and sensible changes
Technical details
no deltav comments to avoid conflicts 2 years down the road
Media
no
Requirements
Breaking changes
no
Changelog
big cl big fun
🆑 yuitop, TheBean, pontaoski, BIGZi0348, deltanedas, ArZarLordOfMango, themias, Blackern5000