Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fingerprint taking improvements #31864

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

godisdeadLOL
Copy link
Contributor

@godisdeadLOL godisdeadLOL commented Sep 5, 2024

About the PR

Some improvements to fingerprint taking as requested in linked issue.
resolves #31843

Why / Balance

realism

Technical details

Raising TryAccessFingerprintEvent to check if some inventory item blocks taking the fingerprint. Doing it for taking and applying fingerprints.

Media

fingers.mp4

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑 yuitop

  • tweak: Fingerless gloves no more blocking taking the fingerprint.

@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Sep 5, 2024
@Everturning
Copy link

hard suits shouldn't block fingerprints bc that's just annoying and doesn't make the game more fun

@godisdeadLOL
Copy link
Contributor Author

Good argument. Should it let you leave fingerprints?

@Everturning
Copy link

if you can take fingerprints then yeah it should make fingerprints too

@godisdeadLOL
Copy link
Contributor Author

Ok. I'll just revert some changes.

@lzk228
Copy link
Contributor

lzk228 commented Sep 5, 2024

@BolloTea
Copy link

BolloTea commented Sep 5, 2024

Ideally, hard suits should leave their unique fibers. Not fun, someone might say, but variety for a detective

@godisdeadLOL
Copy link
Contributor Author

Thanks for feedback. I'll try to improve my code.

@godisdeadLOL godisdeadLOL marked this pull request as draft September 5, 2024 20:44
@godisdeadLOL godisdeadLOL force-pushed the forensic-finger-checking branch from 94772be to 2423f17 Compare September 5, 2024 20:44
@godisdeadLOL godisdeadLOL marked this pull request as ready for review September 5, 2024 20:59
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 12, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@eoineoineoin eoineoineoin added T: Bugfix Type: Bugs and/or bugfixes P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it A: Security Area: Security department, including Detectives, HoS and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 22, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Security Area: Security department, including Detectives, HoS D3: Low Difficulty: Some codebase knowledge required. Merge Conflict P3: Standard Priority: Default priority for repository items. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted S: Needs Review Status: Requires additional reviews before being fully accepted T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it T: Bugfix Type: Bugs and/or bugfixes T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't use forensics pad on person with fingerless gloves
7 participants