-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fingerprint taking improvements #31864
base: master
Are you sure you want to change the base?
Fingerprint taking improvements #31864
Conversation
hard suits shouldn't block fingerprints bc that's just annoying and doesn't make the game more fun |
Good argument. Should it let you leave fingerprints? |
if you can take fingerprints then yeah it should make fingerprints too |
Ok. I'll just revert some changes. |
Ideally, hard suits should leave their unique fibers. Not fun, someone might say, but variety for a detective |
Content.Server/Forensics/Components/FingerprintMaskComponent.cs
Outdated
Show resolved
Hide resolved
Thanks for feedback. I'll try to improve my code. |
94772be
to
2423f17
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
About the PR
Some improvements to fingerprint taking as requested in linked issue.
resolves #31843
Why / Balance
realism
Technical details
Raising
TryAccessFingerprintEvent
to check if some inventory item blocks taking the fingerprint. Doing it for taking and applying fingerprints.Media
fingers.mp4
Requirements
Breaking changes
Changelog
🆑 yuitop