Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mypy precommit hook failing in CI #311

Closed
DominicOram opened this issue Jan 30, 2024 · 0 comments · Fixed by #470
Closed

Mypy precommit hook failing in CI #311

DominicOram opened this issue Jan 30, 2024 · 0 comments · Fixed by #470

Comments

@DominicOram
Copy link
Contributor

The mypy precommit hook is failing in CI. See https://github.com/DiamondLightSource/dodal/actions/runs/7710802756/job/21014898655. It looks like it is an issue with the pydantic/mypy interactions and so it may be that moving to pydantic v2.0 will fix this.

This has been temporarily removed to allow for a new release to be created but we should put it back.

Acceptance Criteria

  • The mypy precommit hooks are reinstated
  • They work in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace black with ruff DiamondLightSource/dodal
1 participant
@DominicOram