Replace black with ruff #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
DominicOram
requested changes
Apr 25, 2024
There was a problem hiding this comment.
This is fine by me, just a few places you missed. Some docs mention black:
dodal/docs/developer/how-to/lint.rst
Line 4 in 081f82c
Comment on lines
-27
to
-34
| # Re-enable after https://github.com/DiamondLightSource/dodal/issues/311 | ||
| # - repo: https://github.com/pre-commit/mirrors-mypy | ||
| # rev: v1.7.1 | ||
| # hooks: | ||
| # - id: mypy | ||
| # files: 'src/.*\.py$' | ||
| # additional_dependencies: [types-requests, pydantic] | ||
| # args: ["--ignore-missing-imports", "--show-traceback", "--no-strict-optional"] |
There was a problem hiding this comment.
Should: If we're going to remove this can we close #311?
There was a problem hiding this comment.
Yes, in the template typing is not handled in precommit, you do it with tox -e type-checking (in dodal it is currently tox -e mypy), which also runs in CI. Will add a closes.
2 tasks
callumforrester
force-pushed
the
remove-black
branch
from
97cbdf1 to
06c8e4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #311
CI was starting to fail due to minor disagreements between black and ruff. This PR switches to the ruff formatter as standard like the copier template: https://github.com/DiamondLightSource/python-copier-template/blob/main/.pre-commit-config.yaml
Instructions to reviewer on how to test:
UndulatorDCMto ophyd-async #461 and see if it fixes CIChecks for reviewer