Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added better docstrings for the attenuator #133

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

DominicOram
Copy link
Contributor

See DiamondLightSource/hyperion#835

Hopefully makes it clearer what units to use

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #133 (e9d01e1) into main (c184692) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage   89.70%   89.70%           
=======================================
  Files          60       60           
  Lines        2030     2030           
=======================================
  Hits         1821     1821           
  Misses        209      209           
Files Changed Coverage Δ
src/dodal/devices/attenuator.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@d-perl d-perl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very helpful

@DominicOram DominicOram merged commit 443c1fd into main Aug 3, 2023
@DominicOram DominicOram deleted the artemis_835_trans_docs branch August 3, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants