Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Fix issue with transmission being set incorrectly #842

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

DominicOram
Copy link
Collaborator

@DominicOram DominicOram commented Jul 31, 2023

Fixes #835

Review GDA too https://gerrit.diamond.ac.uk/c/gda/gda-mx/+/39641

Also see DiamondLightSource/dodal#133

To test:

  1. Run tests
  2. Confirm GDA calls Artemis correctly still using the above gerrit change see instructions here

* Rename to be more explicit what units are expected externally
* Convert to percentage before sending to ispyb
@DominicOram DominicOram requested a review from d-perl July 31, 2023 19:53
@DominicOram
Copy link
Collaborator Author

Linting issues fixed in #841

Copy link
Contributor

@d-perl d-perl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Quite apart from fixing a bug, I love to see units in names. Approved GDA side too.

@DominicOram DominicOram merged commit f66795f into main Aug 3, 2023
@DominicOram DominicOram deleted the 835_transmission_bug branch August 3, 2023 07:08
rtuck99 added a commit that referenced this pull request Jul 30, 2024
rtuck99 added a commit that referenced this pull request Aug 6, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artemis setting transmission incorrectly
2 participants