Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide zocalo with more info for GPU analysis #359

Merged
merged 6 commits into from
Mar 7, 2024

Conversation

DominicOram
Copy link
Contributor

Fixes DiamondLightSource/hyperion#1091

Instructions to reviewer on how to test:

  1. Confirm tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.36%. Comparing base (f18f513) to head (5b3703c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
+ Coverage   93.34%   93.36%   +0.02%     
==========================================
  Files          89       89              
  Lines        3335     3346      +11     
==========================================
+ Hits         3113     3124      +11     
  Misses        222      222              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@d-perl d-perl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks

@DominicOram DominicOram merged commit d78371f into main Mar 7, 2024
16 checks passed
@DominicOram DominicOram deleted the hyperion_1091_provide_zocalo_with_more_info branch March 7, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send zocalo information on the acquisition id and number of images
2 participants