This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Provide zocalo with more info for GPU analysis #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-perl
reviewed
Mar 6, 2024
|
Merge was non-trivial, could you re-review @dperl-dls? |
d-perl
approved these changes
Mar 7, 2024
| ): | ||
| @TRACER.start_as_current_span(DO_FGS) | ||
| @bpp.set_run_key_decorator(DO_FGS) | ||
| @bpp.run_decorator( | ||
| md={ | ||
| "subplan_name": DO_FGS, | ||
| "zocalo_environment": zocalo_environment, | ||
| "scan_points": scan_points, |
There was a problem hiding this comment.
On second thought I actually don't like this in the plan, I think we should do it in the callbacks instead, but I'm happy to leave it as is because I think it fits nicely in #1217
There was a problem hiding this comment.
Do what in the callbacks? Create the points out of the parameters?
There was a problem hiding this comment.
yeah, or out of the grid scan info, whichever
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
…Source/1091_provide_zocalo_with_more_info_part_2 Provide zocalo with more info for GPU analysis
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1091
Link to dodal PR: DiamondLightSource/dodal#359
To test: