Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ExtendedEpicsMotor for smargon omega #367

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

d-perl
Copy link
Contributor

@d-perl d-perl commented Mar 8, 2024

Needed for Hyperion 685

Instructions to reviewer on how to test:

  1. Check nothing is broken

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards

@d-perl d-perl changed the title hyperion #685 use ExtendedEpicsMotor for smargon omega Use ExtendedEpicsMotor for smargon omega Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.39%. Comparing base (4cddb79) to head (9930578).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #367   +/-   ##
=======================================
  Coverage   93.39%   93.39%           
=======================================
  Files          90       90           
  Lines        3362     3362           
=======================================
  Hits         3140     3140           
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, ta

@d-perl d-perl merged commit 19efffb into main Mar 12, 2024
16 checks passed
@d-perl d-perl deleted the hyperion_685_use_vmax_for_rotation branch March 12, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants