This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Use VMAX for resetting omega before and after rotation scans #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-perl
changed the title
DominicOram
suggested changes
Mar 11, 2024
Comment on lines
+271
to
+272
| yield from bps.rd(composite.smargon.omega.max_velocity) | ||
| or DEFAULT_MAX_VELOCITY |
There was a problem hiding this comment.
Should: Why do we have a default in here? In case the PV doesn't exist - we have bigger problems. For the unit tests - we should just be setting up the mock device properly
There was a problem hiding this comment.
I figured in case it was 0 for some reason, I don't know how likely it is for the smargon or VMAX specifically but we often have epics motor fields with nothing in them
There was a problem hiding this comment.
I think that's very unlikely but I'm not that bothered
DominicOram
approved these changes
Mar 14, 2024
Comment on lines
+271
to
+272
| yield from bps.rd(composite.smargon.omega.max_velocity) | ||
| or DEFAULT_MAX_VELOCITY |
There was a problem hiding this comment.
I think that's very unlikely but I'm not that bothered
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
…Source/685_use_vmax_for_rotation Use VMAX for resetting omega before and after rotation scans
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #685
Uses the
max_velocityfrom theExtendedEpicsMotorto reset velocity for rotation scansLink to dodal PR (if required): 367
To test: