Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to robot to do a robot load #374

Merged
merged 7 commits into from
Mar 24, 2024

Conversation

DominicOram
Copy link
Contributor

Fixes DiamondLightSource/hyperion#1234

Instructions to reviewer on how to test:

  1. Confirm unit tests and system tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.52%. Comparing base (30815f1) to head (a8034f3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
+ Coverage   93.45%   93.52%   +0.06%     
==========================================
  Files          90       90              
  Lines        3377     3412      +35     
==========================================
+ Hits         3156     3191      +35     
  Misses        221      221              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@d-perl d-perl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@DominicOram DominicOram merged commit 3773c90 into main Mar 24, 2024
14 checks passed
@DominicOram DominicOram deleted the hyperion_1234_robot_load branch March 24, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Robot Load: Load a given sample
2 participants