-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hyperion 1474: Save the Panda #702
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
==========================================
+ Coverage 94.24% 94.33% +0.09%
==========================================
Files 110 111 +1
Lines 4399 4469 +70
==========================================
+ Hits 4146 4216 +70
Misses 253 253 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main comment is I think this should be specifically for saving the panda, rather than a generic device save. Let me know if you disagree. Also, we should protect against overwriting a previous yaml file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more comments, sorry. Also, CI is complaining about lines not being covered by tests
src/dodal/devices/util/save_panda.py
Outdated
module_name = module_name_for_beamline(beamline) | ||
devices, exceptions = make_all_devices( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only need to create the panda device here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was being lazy - we don't seem to have a nice function for creating only one named device, only one for creating everything. I will create one.
24d0ade
to
c516272
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one spiralled a bit, sorry - looks good I think! Longer term it might be nice to have something similar to the dodal connect
command, like dodal save_device args
, but this is fine for now. Also, because we can't connect to PVA signals from the office network, this will only work on beamline machines.
Part of DiamondLightSource/hyperion#1474
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}