This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
PandA grid scans: Safeguard against varying smargon speed #1474
Comments
olliesilvester
changed the title
PandA grid scans: Get the SEQ table to handle repeats and PULSE width
PandA grid scans: Safeguard against varying smargon speed
Jul 5, 2024
@olliesilvester says this is medium (the rest of us think large) @olliesilvester and @DominicOram are banned from doing this ticket so other people can get some panda experience |
See #1485 for the PCAP part |
rtuck99
added a commit
that referenced
this issue
Jul 22, 2024
…internally rather than using clock generator. * Add saved new panda layout inc. screehshot. * Update unit tests
Closed
rtuck99
added a commit
to DiamondLightSource/dodal
that referenced
this issue
Jul 23, 2024
rtuck99
added a commit
to DiamondLightSource/dodal
that referenced
this issue
Jul 23, 2024
4 tasks
rtuck99
added a commit
that referenced
this issue
Jul 24, 2024
rtuck99
added a commit
that referenced
this issue
Jul 24, 2024
rtuck99
added a commit
that referenced
this issue
Jul 24, 2024
Waiting on testing time on the beamline - better to do with beam |
rtuck99
added a commit
to DiamondLightSource/dodal
that referenced
this issue
Aug 6, 2024
rtuck99
added a commit
to DiamondLightSource/dodal
that referenced
this issue
Aug 6, 2024
rtuck99
added a commit
that referenced
this issue
Aug 7, 2024
…internally rather than using clock generator. * Add saved new panda layout inc. screehshot. * Update unit tests
rtuck99
added a commit
that referenced
this issue
Aug 7, 2024
rtuck99
added a commit
that referenced
this issue
Aug 7, 2024
rtuck99
added a commit
to DiamondLightSource/dodal
that referenced
this issue
Aug 7, 2024
* (DiamondLightSource/hyperion#1474) Add cli tool to save pandas * (DiamondLightSource/hyperion#1474) fixes to save_panda script * Add unit test for saving the panda * Make pyright happy * Changes to make command more specific to pandas * Add additional unit test coverage of argument parsing, force option * Fix CI test failure due to polluting the environment * Construct only the necessary devices when saving the panda * Additional code coverage
rtuck99
added a commit
that referenced
this issue
Aug 7, 2024
* (#1474) Configure panda sequencer table to generate trigger sequence internally rather than using clock generator. * Add saved new panda layout inc. screehshot. * Update unit tests * (#1474) move save-panda to dodal * (#1474) Tidy up documentation * Make pyright happy * Remove redundant comment from tests * (#1474) load the .yaml device layout as a module resource * Fix CI unit test failure due to bluesky event loop not running * Simplify the sequencer table as per PR comment * Update docstring
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this issue
Aug 23, 2024
* (DiamondLightSource/hyperion#1474) Configure panda sequencer table to generate trigger sequence internally rather than using clock generator. * Add saved new panda layout inc. screehshot. * Update unit tests * (DiamondLightSource/hyperion#1474) move save-panda to dodal * (DiamondLightSource/hyperion#1474) Tidy up documentation * Make pyright happy * Remove redundant comment from tests * (DiamondLightSource/hyperion#1474) load the .yaml device layout as a module resource * Fix CI unit test failure due to bluesky event loop not running * Simplify the sequencer table as per PR comment * Update docstring
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Our current panda setup is meant to do the following:
This assumes that the PandA is going at exactly the right speed by the time we get to bullet point 2. If we are going too quickly or too slowly, the number of triggers received may be off by a tiny amount. The last time we tested the panda, we saw an occasional missing trigger. We concluded that this was either down to what has just been described, or due to lost encoder counts due to accelerating the smargon too quickly.
We should instead do the following:
This will rule out missing triggers from the smargon going at the slight wrong speed. If the speed is wrong, we will still get the triggers, but they will be in a weird place (and this will be obvious from data collection). When PVT scans are working, it will setup the panda in a similar way, but it will be nice to do it here first so we can compare the times of panda scans using the motion controller and using the ophyd-async flyscan
Acceptance Criteria
Do the above, and update documentation https://github.com/DiamondLightSource/hyperion/wiki/PandA-constant%E2%80%90motion-scanning
The text was updated successfully, but these errors were encountered: