Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Allow reading apertures #1032

Closed
DominicOram opened this issue Dec 8, 2023 · 0 comments · Fixed by #1113 or DiamondLightSource/dodal#301
Closed

Allow reading apertures #1032

DominicOram opened this issue Dec 8, 2023 · 0 comments · Fixed by #1113 or DiamondLightSource/dodal#301
Assignees
@stan-dot
Labels
good first issue Good for newcomers

Comments

@DominicOram
Copy link
Collaborator

DominicOram commented Dec 8, 2023 •
edited by stan-dot
Loading

Currently we cannot read the state of the apertures. Reading them would be useful to:

Acceptance Criteria

  • The beam size is read from the ApertureScatterguard device and passed into ispyb, it is removed from expected external params
  • It is possible to read a string of the currently selected aperture (as required by Rotation scan ispyb comment should contain metadata #933) [edit] - that is radius signal and values 100, 50 , 20 um (μm)
@DominicOram DominicOram added the good first issue Good for newcomers label Dec 8, 2023
@DominicOram DominicOram moved this to Backlog in Hyperion Dec 8, 2023
@DominicOram DominicOram changed the title Read apertures for beam size in ispyb Allow reading apertures Dec 12, 2023
@DominicOram DominicOram mentioned this issue Dec 12, 2023
Closed
@DominicOram DominicOram moved this from Backlog to Todo This Sprint in Hyperion Dec 12, 2023
@DominicOram DominicOram moved this from Todo This Sprint to In Progress in Hyperion Jan 12, 2024
@stan-dot stan-dot mentioned this issue Jan 19, 2024
Closed
@stan-dot stan-dot mentioned this issue Feb 2, 2024
Merged
DominicOram added a commit to DiamondLightSource/dodal that referenced this issue Mar 6, 2024
@DominicOram
(DiamondLightSource/hyperion#1032) Minor changes from review
f8ae6a0
DominicOram added a commit that referenced this issue Mar 6, 2024
@DominicOram
(#1032) Some tidying up from review
a0222be
@DominicOram DominicOram mentioned this issue Mar 6, 2024
Merged
2 tasks
DominicOram added a commit to DiamondLightSource/dodal that referenced this issue Mar 6, 2024
@DominicOram
(DiamondLightSource/hyperion#1032) Fix test
c30fbbd
DominicOram added a commit that referenced this issue Mar 6, 2024
@DominicOram
(#1032) Fix tests after review
e6fb3fd
@DominicOram DominicOram mentioned this issue Mar 6, 2024
Closed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hyperion Mar 6, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@DominicOram
(DiamondLightSource/hyperion#1032) Some tidying up from review
a648eee
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@DominicOram
(DiamondLightSource/hyperion#1032) Fix tests after review
a1818d8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stan-dot stan-dot

Labels
good first issue Good for newcomers
Projects
Hyperion
Archived in project
Milestone
No milestone
2 participants
@DominicOram @stan-dot