Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Allow reading the aperture name and size from the device #1113

Merged
merged 23 commits into from
Mar 6, 2024

Conversation

stan-dot
Copy link
Contributor

@stan-dot stan-dot commented Feb 2, 2024

Fixes #1032

Link to dodal PR (if required): DiamondLightSource/dodal#301

(remember to update setup.cfg with the dodal commit tag if you need it for tests to pass!)

To test:

  1. Do thing x
  2. Confirm thing y happens

@stan-dot stan-dot self-assigned this Feb 2, 2024
@stan-dot stan-dot marked this pull request as ready for review February 6, 2024 12:35
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: Patch coverage is 97.14286% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.88%. Comparing base (e3b7353) to head (be7bf8f).
Report is 138 commits behind head on main.

❗ Current head be7bf8f differs from pull request most recent head e6fb3fd. Consider uploading reports for the commit e6fb3fd to get more accurate results

Files Patch % Lines
...rion/external_interaction/ispyb/ispyb_dataclass.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1113      +/-   ##
==========================================
- Coverage   92.96%   92.88%   -0.09%     
==========================================
  Files          69       65       -4     
  Lines        3413     3343      -70     
==========================================
- Hits         3173     3105      -68     
+ Misses        240      238       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you. Some comments in code.

I really like all the tidying up of types etc. you've done but for future reference it helps the reviewer if those are split into a different PR. With them mixed I end up looking at the changes thinking "How does this fit into the work needed for aperture changes" then realising it doesn't and instead having to shift into "Do I think is this functionally the same and tidier, is it sufficiently covered in tests to check that". It also makes it harder to work out what happened if a mistake is made in that refactoring as people may look at the release notes to work out what introduced the mistake and not expect it to part of what looks like an unrelated change.

@stan-dot stan-dot requested a review from DominicOram February 16, 2024 09:35
Copy link
Collaborator

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. In the interests of getting this merged I have spun remaining issues out to #1228

@DominicOram DominicOram merged commit b7e632c into main Mar 6, 2024
5 checks passed
@DominicOram DominicOram deleted the 1032-rebased-apertures branch March 6, 2024 16:15
@DominicOram DominicOram changed the title add apertures Allow reading the aperture name and size from the device Mar 6, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
…Source/1032-rebased-apertures

add apertures
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow reading apertures
2 participants