-
Notifications
You must be signed in to change notification settings - Fork 5
Allow reading the aperture name and size from the device #1113
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1113 +/- ##
==========================================
- Coverage 92.96% 92.88% -0.09%
==========================================
Files 69 65 -4
Lines 3413 3343 -70
==========================================
- Hits 3173 3105 -68
+ Misses 240 238 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you. Some comments in code.
I really like all the tidying up of types etc. you've done but for future reference it helps the reviewer if those are split into a different PR. With them mixed I end up looking at the changes thinking "How does this fit into the work needed for aperture changes" then realising it doesn't and instead having to shift into "Do I think is this functionally the same and tidier, is it sufficiently covered in tests to check that". It also makes it harder to work out what happened if a mistake is made in that refactoring as people may look at the release notes to work out what introduced the mistake and not expect it to part of what looks like an unrelated change.
src/hyperion/external_interaction/ispyb/store_datacollection_in_ispyb.py
Outdated
Show resolved
Hide resolved
tests/unit_tests/experiment_plans/test_flyscan_xray_centre_plan.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks. In the interests of getting this merged I have spun remaining issues out to #1228
…Source/1032-rebased-apertures add apertures
Fixes #1032
Link to dodal PR (if required): DiamondLightSource/dodal#301
(remember to update
setup.cfg
with the dodal commit tag if you need it for tests to pass!)To test: