Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Dodal loggers not initialised in callback process #1252

Closed
DominicOram opened this issue Mar 13, 2024 · 3 comments · Fixed by #1287
Closed

Dodal loggers not initialised in callback process #1252

DominicOram opened this issue Mar 13, 2024 · 3 comments · Fixed by #1287
Assignees
@rtuck99

Comments

@DominicOram
Copy link
Collaborator

When interacting with zocalo we log into the dodal logger. However, this is being done in the callback process. It looks like the dodal loggers are not initialised in this process and so logs inside e.g. zocalo_interaction are not getting logged to graylog.

Acceptance Criteria

  • Logs in zocalo_interaction are correctly sent to graylog etc.
@DominicOram DominicOram moved this to Backlog in Hyperion Mar 13, 2024
@DominicOram DominicOram moved this from Backlog to Candidates for Next Sprint in Hyperion Mar 25, 2024
@DominicOram DominicOram moved this from Candidates for Next Sprint to Todo This Sprint in Hyperion Mar 25, 2024
@DominicOram
Copy link
Collaborator Author

We think XS/S

@olliesilvester olliesilvester self-assigned this Mar 28, 2024
@DominicOram DominicOram moved this from Todo This Sprint to In Progress in Hyperion Mar 28, 2024
@olliesilvester olliesilvester mentioned this issue Mar 28, 2024
Merged
@DominicOram DominicOram moved this from In Progress to Review in Hyperion Mar 28, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in Hyperion Mar 28, 2024
rtuck99 added a commit that referenced this issue Apr 2, 2024
@rtuck99
(#1252) Fix logging unit test failure
ed32ef6
@rtuck99 rtuck99 mentioned this issue Apr 2, 2024
Merged
@rtuck99
Copy link
Contributor

rtuck99 commented Apr 2, 2024

Reopened as unit test failures started happening

@rtuck99 rtuck99 reopened this Apr 2, 2024
@rtuck99 rtuck99 assigned rtuck99 and unassigned olliesilvester Apr 2, 2024
@rtuck99 rtuck99 moved this from Done to Review in Hyperion Apr 2, 2024
@DominicOram DominicOram moved this from Review to In Progress in Hyperion Apr 2, 2024
@rtuck99 rtuck99 moved this from In Progress to Review in Hyperion Apr 2, 2024
rtuck99 added a commit that referenced this issue Apr 3, 2024
@rtuck99
(#1252) remove teardown check for logging option as per PR review com…
96ef622 
…ment
d-perl added a commit that referenced this issue Apr 3, 2024
@d-perl
Merge pull request #1288 from DiamondLightSource/1252_fix_logging_uni…
3d5ab75 
…t_test_failures

(#1252) Fix logging unit test failure
@DominicOram
Copy link
Collaborator Author

Now fixed by #1288

@github-project-automation github-project-automation bot moved this from Review to Done in Hyperion Apr 5, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
(DiamondLightSource/hyperion#1252) Fix logging unit test failure
28ed371
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
(DiamondLightSource/hyperion#1252) remove teardown check for logging …
a9fc7d7 
…option as per PR review comment
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@d-perl
Merge pull request DiamondLightSource/hyperion#1288 from DiamondLight…
39e3278 
…Source/1252_fix_logging_unit_test_failures

(DiamondLightSource/hyperion#1252) Fix logging unit test failure
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rtuck99 rtuck99

Labels
None yet
Projects
Hyperion
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Initialise dodal logger in external callbacks DiamondLightSource/hyperion
3 participants
@rtuck99 @DominicOram @olliesilvester