This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
(#1252) Fix logging unit test failure #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-perl
suggested changes
Apr 2, 2024
tests/conftest.py
Outdated
| if "dodal.beamlines.beamline_utils" in sys.modules: | ||
| sys.modules["dodal.beamlines.beamline_utils"].clear_devices() | ||
| markers = [m.name for m in item.own_markers] | ||
| if item.config.getoption("logging") and "skip_log_setup" in markers: |
There was a problem hiding this comment.
I don't think this should check for the option - we want to tear down after these tests regardless of whether we are in CI or local, no?
There was a problem hiding this comment.
Hmm yes on reflection I think you are right, the tests will execute even if logging is disabled and may still do stuff.
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
…Source/1252_fix_logging_unit_test_failures (DiamondLightSource/hyperion#1252) Fix logging unit test failure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes unit test failures introduced in previous fix for #1252
Link to dodal PR (if required): #N/A
To test: