Screen and collect not working

[DominicOram]

When we do a screen and collect the screening should first put into ispyb with the experiment kind of Characterization, this causes agamemnon to tell GDA to wait for the screening to finish before the next collection. The experiment kind is passed into Hyperion straight from GDA. It looks as though the latest Hyperion version is not passing this into ispyb e.g. https://ispyb.diamond.ac.uk/samples/sid/5536566 should be a screen + collect.

Acceptance Criteria

• Hyperion correctly passes experiment kind into ispyb from GDA
• Screen and collect works
• There is a test that would have caught this

[d-perl]

If the ispyb_experiment_type parameter needs to be passed in from agamemnon long-term it should be moved out of the TemporaryIspybExtras and into some other param class

[DominicOram]

We think small

[d-perl]

There is currently logic in the ISPyB callback that determines if a collection is characterisation, we should also use this value rather than the number of images, probably with an enum corresponding to the valid collection types

[d-perl]

Turns out there was already both a mechanism for this and a test for it, the use of it just got lost in the new parameter generation of ispyb params.