This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Correctly handle passed-in ISPyB experiment type (i.e. "characterization") #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicOram
suggested changes
May 10, 2024
| @@ -189,7 +235,7 @@ class OptionalGonioAngleStarts(BaseModel): | |||
|
|
|||
|
|
|||
| class TemporaryIspybExtras(BaseModel): | |||
| # for while we still need ISpyB params - to be removed in #1277 and/or #43 | |||
| # for while we still need ISpyB params_to be removed in #1277 and/or #43 | |||
There was a problem hiding this comment.
Nit: Why did this get changed?
There was a problem hiding this comment.
overeager find and replace 🤦♂️
There was a problem hiding this comment.
Cool, can you just fix this then happy to merge then
DominicOram
approved these changes
May 13, 2024
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
…Source/1360_handle_characterisation Correctly handle passed-in ISPyB experiment type (i.e. "characterization")
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1360
Ensures ispyb experiment type is correctly passed along from parameters
To test: