Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Add dodal and nexgen version to release notes #819

Closed
DominicOram opened this issue Jul 20, 2023 · 2 comments · Fixed by #1097 or #1305
Closed

Add dodal and nexgen version to release notes #819

DominicOram opened this issue Jul 20, 2023 · 2 comments · Fixed by #1097 or #1305
Assignees
@rtuck99
Labels
good first issue Good for newcomers

Comments

@DominicOram
Copy link
Collaborator

Changes in dodal and nexgen can have quite big affects on the Artemis. We should automatically add a link to the release notes of the dodal/nexgen version we're using in the Artemis release notes
@DominicOram DominicOram added the good first issue Good for newcomers label Jul 20, 2023
@DominicOram DominicOram moved this to Backlog in Hyperion Jul 20, 2023
subinsaji added a commit that referenced this issue Oct 16, 2023
@subinsaji
(#819) replaced test with correct stop event from conftest.py
55c1921
@DominicOram DominicOram changed the title Add dodal and nexgn version to release notes Add dodal and nexgen version to release notes Jan 18, 2024
@rtuck99 rtuck99 self-assigned this Jan 18, 2024
@DominicOram DominicOram moved this from Backlog to In Progress in Hyperion Jan 18, 2024
rtuck99 added a commit that referenced this issue Jan 25, 2024
@rtuck99
(#819) Initial attempt at github workflow to pin versions
f56b6d3
@rtuck99 rtuck99 mentioned this issue Jan 25, 2024
Merged
@DominicOram DominicOram moved this from In Progress to Review in Hyperion Jan 25, 2024
@DominicOram DominicOram moved this from Review to In Progress in Hyperion Jan 25, 2024
@rtuck99 rtuck99 moved this from In Progress to Review in Hyperion Jan 29, 2024
rtuck99 added a commit that referenced this issue Jan 30, 2024
@rtuck99
(#819) Initial attempt at github workflow to pin versions
5b88ce8
rtuck99 added a commit that referenced this issue Jan 30, 2024
@rtuck99
(#819) Add some unit tests
14da16a
rtuck99 added a commit that referenced this issue Jan 31, 2024
@rtuck99
(#819) Fix unit test bug
f02716a
rtuck99 added a commit that referenced this issue Feb 1, 2024
@rtuck99
Merge pull request #1097 from DiamondLightSource/819_add_dodal_and_ne…
bf65e2f 
…xgen_version_to_release_notes

(#819) Initial attempt at github workflow to pin versions
@github-project-automation github-project-automation bot moved this from Review to Done in Hyperion Feb 1, 2024
@rtuck99
Copy link
Contributor

rtuck99 commented Mar 14, 2024 •
edited
Loading

The pre-release workflow unfortunately doesn't result in updated release notes as the release notes reference PRs not commits. Additional steps need to occur to edit the release notes with the commit comment.

A secondary issue is that dependencies which are not available on pypi, will be pinned to the wrong version. At the moment, dodal cannot be published due to its dependency on ophyd-async

@rtuck99 rtuck99 reopened this Mar 14, 2024
@rtuck99
Copy link
Contributor

rtuck99 commented Apr 9, 2024

Version pinning is also using the wrong syntax @ instead of ==

rtuck99 added a commit that referenced this issue Apr 10, 2024
@rtuck99
(#819) use the correct matching operator in setup.cfg when pinning ve…
9ee87dd 
…rsions
rtuck99 added a commit that referenced this issue Apr 10, 2024
@rtuck99
(#819) Additional steps to create a release and edit release notes
f04e9e9
rtuck99 added a commit that referenced this issue Apr 10, 2024
@rtuck99
(#819) Additional steps to create a release and edit release notes
58471ef
rtuck99 added a commit that referenced this issue Apr 10, 2024
@rtuck99
(#819) Additional steps to create a release and edit release notes
6481545
rtuck99 added a commit that referenced this issue Apr 10, 2024
@rtuck99
(#819) Additional steps to create a release and edit release notes
0a5e07a
rtuck99 added a commit that referenced this issue Apr 10, 2024
@rtuck99
(#819) Additional steps to create a release and edit release notes
c3e0bdb
rtuck99 added a commit that referenced this issue Apr 10, 2024
@rtuck99
(#819) Additional steps to create a release and edit release notes
277eff3
rtuck99 added a commit that referenced this issue Apr 10, 2024
@rtuck99
(#819) Additional steps to create a release and edit release notes
04b2bcd
rtuck99 added a commit that referenced this issue Apr 10, 2024
@rtuck99
(#819) Additional steps to create a release and edit release notes
1182413
@rtuck99 rtuck99 mentioned this issue Apr 10, 2024
Merged
@DominicOram DominicOram moved this from Done to Review in Hyperion Apr 10, 2024
@DominicOram DominicOram moved this from Review to In Progress in Hyperion Apr 30, 2024
rtuck99 added a commit that referenced this issue May 14, 2024
@rtuck99
(#819) update setup.cfg to identify which dependencies should be pinn…
ee7c6b9 
…ed explicitly
rtuck99 added a commit that referenced this issue May 14, 2024
@rtuck99
(#819) Correctly handle inline comments
9f6b1ae
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hyperion May 17, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
(DiamondLightSource/hyperion#819) Initial attempt at github workflow …
d53b49f 
…to pin versions
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
(DiamondLightSource/hyperion#819) Add some unit tests
5a7f179
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
(DiamondLightSource/hyperion#819) Fix unit test bug
ffc757a
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
Merge pull request DiamondLightSource/hyperion#1097 from DiamondLight…
c76a091 
…Source/819_add_dodal_and_nexgen_version_to_release_notes

(DiamondLightSource/hyperion#819) Initial attempt at github workflow to pin versions
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
(DiamondLightSource/hyperion#819) use the correct matching operator i…
42c5729 
…n setup.cfg when pinning versions
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
(DiamondLightSource/hyperion#819) Additional steps to create a releas…
5150999 
…e and edit release notes
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
(DiamondLightSource/hyperion#819) update setup.cfg to identify which …
39c3311 
…dependencies should be pinned explicitly
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
(DiamondLightSource/hyperion#819) Correctly handle inline comments
29fe082
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rtuck99 rtuck99

Labels
good first issue Good for newcomers
Projects
Hyperion
Archived in project
Milestone
No milestone
2 participants
@rtuck99 @DominicOram