-
Notifications
You must be signed in to change notification settings - Fork 5
819 add dodal and nexgen versions to release notes #1305
819 add dodal and nexgen versions to release notes #1305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created the release at https://github.com/DiamondLightSource/hyperion/releases/tag/untagged-0eb09fe04a1a13594f36 but it had some issues:
- Must: The code was pinned to
dodal == 1.13.1
but the latest is https://github.com/DiamondLightSource/dodal/releases/tag/1.22.0 (https://pypi.org/project/dls-dodal/) - Could: It would be better if rather than just saying "these were the versions" links were provided to the release notes
- Nit: I think the version numbers are less interesting than what's changed so can we put them at the bottom of the release notes?
Hmm, looking at the logs, it installs the right version of dodal.... then it installs the wrong version on top. Not sure if it's related to the bluesky api conflict but will investigate |
Could be, looks like the |
As discussed, I think the correct answer is that we should have been pinning our |
Ok, I think the blue-api versioning issue is another thing to the dodal versioning issue - I think these are the alternative ways of pinning.
I think it's a toss up between 1 and 2 - 1 has more things pinned but we might update less frequently |
Agreed that will go for option 2 and pin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
this is an improvement, we can always iterate
…Source/819_add_dodal_nexgen_version_to_release_notes_part_2 819 add dodal and nexgen versions to release notes
Fixes #819
Link to dodal PR (if required): #N/A
(remember to update
setup.cfg
with the dodal commit tag if you need it for tests to pass!)To test: