Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Update to ophyd_async shutter #1351

Closed
wants to merge 2 commits into from

Conversation

DominicOram
Copy link
Collaborator

Link to dodal PR (if required): DiamondLightSource/dodal#480

To test:

  1. Confirm tests still pass

@stan-dot
Copy link
Contributor

stan-dot commented May 7, 2024

@DominicOram when you say merge at the same time, you mean into master one day or one PR into another?

@DominicOram
Copy link
Collaborator Author

@DominicOram when you say merge at the same time, you mean into master one day or one PR into another?

Both into main on their respective repos at around the same time

@stan-dot
Copy link
Contributor

stan-dot commented May 8, 2024

not sure what to do about the CI error:

0s
Run item_id="$( gh api graphql -f query='
item_id="$( gh api graphql -f query='
mutation($project:ID!, $pr:ID!) {
addProjectV2ItemById(input: {projectId: $project, contentId: $pr}) {
item {
id
}
}
}' -f project=$PROJECT_ID -f pr=$ISSUE_ID --jq '.data.addProjectV2ItemById.item.id')"

echo 'ITEM_ID='$item_id >> $GITHUB_ENV

shell: /usr/bin/bash -e {0}
env:
PROJECT_ID: "PVT_kwDOABLS0s4AHJ2Y"
STATUS_FIELD_ID: "PVTSSF_lADOABLS0s4AHJ2YzgEH3Zs"
NEW_OPTION_ID: "e133e26f"
GITHUB_TOKEN: ***
ISSUE_ID: null
gh: Could not resolve to a node with the global id of 'null'
Error: Process completed with exit code 1.

@DominicOram
Copy link
Collaborator Author

not sure what to do about the CI error:

You can ignore them. They're for moving issues around the hyperion project board but this isn't being tracked on the hyperion project board

@stan-dot stan-dot self-assigned this May 22, 2024
@DominicOram
Copy link
Collaborator Author

Closing in favour of #1419

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants