Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Firefox #25

Closed
6 tasks done
Jack-Works opened this issue Apr 26, 2019 · 8 comments
Closed
6 tasks done

Support Firefox #25

Jack-Works opened this issue Apr 26, 2019 · 8 comments
Assignees
@Jack-Works @guanbinrui
Labels
Kind: Unattached Priority: P1 (Now) P1 Severity: High The issue reports incorrect functionality, bad functionality, a confusing user experience, etc.

Comments

@Jack-Works
Copy link
Member

Jack-Works commented Apr 26, 2019 •
edited
Loading

Current Status: Available

  • ✔ Background Service
  • ✔ Options Page
  • ✔ Content Script
  • ✔ Injected Script

Components:

  • ✔ Encryption
  • ✔ Decryption
  • ✔ Welcome from the webpage
  • ✔ Welcome from the options page
  • ✔ Auto verify post
  • ✔ Auto verify bio
  • Web Extension Switch to WebExtension API #13
  • Custom events registered many times
  • Inject error Error: "document.documentElement is null"
  • Error: conflictAction prompt not yet implemented in Backup
  • Error: Permission denied to access property Symbol.iterator (addEventListener.ts:40)
  • Publish on Firefox
@Jack-Works Jack-Works added this to the Next Release milestone Apr 26, 2019
@Jack-Works Jack-Works self-assigned this Apr 26, 2019
Jack-Works added a commit that referenced this issue Apr 28, 2019
@Jack-Works
Move polyfills out. (Partly) Test with Firefox #25
a3799d0
@Jack-Works Jack-Works changed the title Test on Firefox Support Firefox Apr 28, 2019
@Jack-Works
Copy link
Member Author

mention for who are interested in Firefox supports in https://www.reddit.com/r/crypto/comments/bevx1s/maskbook_surrender_no_privacy_to_youknowwho/

Jack-Works added a commit that referenced this issue May 13, 2019
@Jack-Works
Try to support Firefox related #25
92fd916 
Signed-off-by: Jack Works <[email protected]>
@Jack-Works
Copy link
Member Author

Jack-Works commented May 14, 2019 •
edited
Loading

Tried again 4072b3c

@Jack-Works
Copy link
Member Author

Related facebook/react#15759

@yisiliu
Copy link
Member

yisiliu commented Jul 10, 2019

assigned @guanbinrui

@Tedko
Copy link
Member

Tedko commented Aug 2, 2019

@guanbinrui expectation?

guanbinrui added a commit that referenced this issue Aug 3, 2019
@guanbinrui
fix(firefox): firing with custom Object become restrictions data
2a4ab48 
communicate with plain json string instead of custom Object
more: https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent

re #25
@guanbinrui guanbinrui mentioned this issue Aug 3, 2019
Closed
7 tasks
@guanbinrui
Copy link
Member

@yisiliu @Tedko @Jack-Works Firefox is fully supported waiting for merge the PR and release.

@Jack-Works
Copy link
Member Author

Will test later

@Jack-Works Jack-Works removed this from the Next Release milestone Aug 3, 2019
@Jack-Works Jack-Works added Priority: P1 (Now) P1 Severity: High The issue reports incorrect functionality, bad functionality, a confusing user experience, etc. Type: Bug and removed Type: Feature labels Aug 3, 2019
guanbinrui added a commit that referenced this issue Aug 3, 2019
@guanbinrui
fix(firefox): firing with custom Object become restrictions data
c3cb73e 
communicate with plain json string instead of custom Object
more: https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent

re #25
Jack-Works pushed a commit that referenced this issue Aug 8, 2019
@guanbinrui @Jack-Works
fix(firefox): firing with custom Object become restrictions data
4109ce6 
communicate with plain json string instead of custom Object
more: https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent

re #25
@Jack-Works
Copy link
Member Author

closed by 0298aa9

@Jack-Works Jack-Works mentioned this issue Aug 27, 2019
Merged
10 tasks
lucasespinosa28 pushed a commit to lucasespinosa28/Maskbook that referenced this issue Dec 13, 2021
@austintgriffith
Merge pull request DimensionDev#25 from TomAFrench/refactor
4c3c88c 
Refactor Account component + others
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jack-Works Jack-Works

@guanbinrui guanbinrui

Labels
Kind: Unattached Priority: P1 (Now) P1 Severity: High The issue reports incorrect functionality, bad functionality, a confusing user experience, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yisiliu @Jack-Works @Tedko @guanbinrui