[Merged] Feature/firefox #83

guanbinrui · 2019-08-03T06:48:45Z

Support Firefox #25

Fix setup-mobile page crashed #97
Fix auto pasting not working in FF;
Fix request camera permission not working in FF;
Fix double error messages when camera permission was denied;
Fix user discover not working in FF;
Fix page flash while loading QR code image;
Support scanning QR code in web worker;

Jack-Works · 2019-08-03T07:47:10Z

Merge branch 'master' of github.com:/...

You can rebase master instead of leaving so many commits

communicate with plain json string instead of custom Object more: https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent re #25

guanbinrui · 2019-08-03T15:55:28Z

@Jack-Works it's clean now.

Jack-Works · 2019-08-05T02:45:28Z

Not sure if this got fixed.

QR scanning is not working
Background page throws "Can't parse the page." it caused by User-Agent, we may fall back to a classic way to fetch the key (Note: feature/multiple-network has done this.)

Jack-Works

Have a try to fix QR scanning on Firefox, good luck

Misaka-0x447f · 2019-08-05T06:26:30Z

Misaka online. testing qr-code.

Misaka-0x447f · 2019-08-05T06:36:28Z

firefox does not support request camera using this api. working on find a polyfill.

guanbinrui · 2019-08-05T07:01:17Z

I'm working on figuring out the difference between Chrome & FF when fetching other user's public key and try to cherry-pick the classic way from feature/multiple-network branch.

Jack-Works · 2019-08-05T08:26:26Z

@guanbinrui you can leave that problem. After multiple network get merged and this branch get rebased, I can fix it

guanbinrui · 2019-08-05T08:33:27Z

@Jack-Works I think it's not the best way of extracting user bio/post content by the 'classic way'. It's easy to break.
What I found that in raw user profile page there is a code snippet:

<div id="intro_container_id"><!-- user bio box html --></div>

so I wonder we can parse the html snippet in FF too.

Misaka-0x447f · 2019-08-05T08:54:24Z

using a polyfill of permissions.query is required? no available polyfill at this time on the npm, only permissions.request available but broken.

use a magic selector to locate bio node in old version profile page

src/social-network/facebook.com/fetch-bio.ts

Misaka-0x447f · 2019-08-06T04:05:33Z

Do you have your prettier enabled?

Emmmmm No force use of prettier in this project. Maybe need to chain it in the webpack and git commit hook.

Jack-Works · 2019-08-07T04:21:47Z

Does this pr ready for review?

Misaka-0x447f · 2019-08-07T08:46:09Z

no the qr component performance problem is not resolved

Does this pr ready for review?

…re/firefox

config-overrides.js

src/social-network-provider/facebook.com/parse-html.ts

src/components/Welcomes/QRScanner/ShapeDetectionPolyfill.ts

use browser.runtime.getURL directly will cause this code to fail in the storybook

This reverts commit 6a80fe7.

SunriseFox

need to test more... it seems that not entire post is used as a thing to decrypt the post, though unable to decrypt may related to GUN.

guanbinrui · 2019-08-08T07:18:05Z

need to test more... it seems that not entire post is used as a thing to decrypt the post, though unable to decrypt may related to GUN.

I'm working on this bug. It looks like maskbook fail to recognize current user.
#/setup-mobile page is crash on this branch too which is fine on master branch.

…re/firefox

Update README.md

guanbinrui mentioned this pull request Aug 3, 2019

Support Firefox #25

Closed

6 tasks

guanbinrui requested review from Jack-Works, SunriseFox and Misaka-0x447f August 3, 2019 06:52

Jack-Works self-assigned this Aug 3, 2019

Jack-Works added the bug label Aug 3, 2019

Jack-Works modified the milestone: Next Release Aug 3, 2019

guanbinrui added 3 commits August 3, 2019 23:53

fix: typo

8e966c5

fix(firefox): firing with custom Object become restrictions data

c3cb73e

communicate with plain json string instead of custom Object more: https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent re #25

fix(firefox): Auto pasting not working when encryption user's posts

815e5b6

guanbinrui force-pushed the feature/firefox branch from a8b9402 to 815e5b6 Compare August 3, 2019 15:54

Jack-Works requested changes Aug 5, 2019

View reviewed changes

Misaka-0x447f self-assigned this Aug 5, 2019

fix(firefox): resolve partially: Can't parse the page

7c09395

use a magic selector to locate bio node in old version profile page

guanbinrui commented Aug 5, 2019

View reviewed changes

src/social-network/facebook.com/fetch-bio.ts Outdated Show resolved Hide resolved

guanbinrui and others added 2 commits August 5, 2019 20:18

style: remove empty line between declaration and block

83dd5f1

fix: works in env that permission api is partly available

3e00eed

guanbinrui added 6 commits August 7, 2019 18:45

build(webpack): add entry for qrcode web worker

852bf85

feat: decode qrcode in web worker

2457180

fix: page flash after qrcode image loaded

bea7c62

fix: duplicate error message

890276d

Merge branch 'master' of github.com:/DimensionDev/Maskbook into featu…

ef7e7c8

…re/firefox

refactor: add TODO tag

0e04589

Jack-Works requested changes Aug 8, 2019

View reviewed changes

config-overrides.js Outdated Show resolved Hide resolved

src/social-network-provider/facebook.com/parse-html.ts Outdated Show resolved Hide resolved

src/components/Welcomes/QRScanner/ShapeDetectionPolyfill.ts Outdated Show resolved Hide resolved

guanbinrui and others added 5 commits August 8, 2019 13:28

fix: use globalThis

9b3ba00

fix: use getUrl

e31689c

use browser.runtime.getURL directly will cause this code to fail in the storybook

fix: no need to parse content of HTMLDivElement

7f3be6f

fix: type in worker

6a80fe7

Revert "fix: type in worker"

d98fb24

This reverts commit 6a80fe7.

Jack-Works previously approved these changes Aug 8, 2019

View reviewed changes

SunriseFox suggested changes Aug 8, 2019

View reviewed changes

Merge branch 'master' of github.com:/DimensionDev/Maskbook into featu…

3d055e1

…re/firefox

guanbinrui dismissed Jack-Works’s stale review via dea3508 August 8, 2019 10:25

fix: #97

ccf2c97

guanbinrui force-pushed the feature/firefox branch from dea3508 to ccf2c97 Compare August 8, 2019 10:47

guanbinrui requested review from SunriseFox and Jack-Works August 8, 2019 10:48

Jack-Works approved these changes Aug 8, 2019

View reviewed changes

SunriseFox approved these changes Aug 8, 2019

View reviewed changes

Jack-Works changed the title ~~Feature/firefox~~ [Merged] Feature/firefox Aug 8, 2019

Jack-Works closed this Aug 8, 2019

Jack-Works deleted the feature/firefox branch August 12, 2019 06:36

lucasespinosa28 pushed a commit to lucasespinosa28/Maskbook that referenced this pull request Dec 13, 2021

Merge pull request DimensionDev#83 from Ro5s/patch-1

a6692c2

Update README.md

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged] Feature/firefox #83

[Merged] Feature/firefox #83

guanbinrui commented Aug 3, 2019 •

edited

Loading

Jack-Works commented Aug 3, 2019

guanbinrui commented Aug 3, 2019 •

edited

Loading

Jack-Works commented Aug 5, 2019

Jack-Works left a comment

Misaka-0x447f commented Aug 5, 2019

Misaka-0x447f commented Aug 5, 2019

guanbinrui commented Aug 5, 2019

Jack-Works commented Aug 5, 2019

guanbinrui commented Aug 5, 2019 •

edited

Loading

Misaka-0x447f commented Aug 5, 2019

Misaka-0x447f commented Aug 6, 2019

Jack-Works commented Aug 7, 2019

Misaka-0x447f commented Aug 7, 2019

SunriseFox left a comment

guanbinrui commented Aug 8, 2019 •

edited

Loading

[Merged] Feature/firefox #83

[Merged] Feature/firefox #83

Conversation

guanbinrui commented Aug 3, 2019 • edited Loading

Jack-Works commented Aug 3, 2019

guanbinrui commented Aug 3, 2019 • edited Loading

Jack-Works commented Aug 5, 2019

Jack-Works left a comment

Choose a reason for hiding this comment

Misaka-0x447f commented Aug 5, 2019

Misaka-0x447f commented Aug 5, 2019

guanbinrui commented Aug 5, 2019

Jack-Works commented Aug 5, 2019

guanbinrui commented Aug 5, 2019 • edited Loading

Misaka-0x447f commented Aug 5, 2019

Misaka-0x447f commented Aug 6, 2019

Jack-Works commented Aug 7, 2019

Misaka-0x447f commented Aug 7, 2019

SunriseFox left a comment

Choose a reason for hiding this comment

guanbinrui commented Aug 8, 2019 • edited Loading

guanbinrui commented Aug 3, 2019 •

edited

Loading

guanbinrui commented Aug 3, 2019 •

edited

Loading

guanbinrui commented Aug 5, 2019 •

edited

Loading

guanbinrui commented Aug 8, 2019 •

edited

Loading