Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beta3で取り込まれた未検証のPRをRevert #5131

Merged
merged 5 commits into from
Sep 1, 2021

Conversation

chihiro-adachi
Copy link
Contributor

概要(Overview・Refs Issue)

beta3で未検証のPRが取り込まれたため、該当のPRをrevertしています

方針(Policy)

実装に関する補足(Appendix)

テスト(Test)

相談(Discussion)

マイナーバージョン互換性保持のための制限事項チェックリスト

  • 既存機能の仕様変更
  • フックポイントの呼び出しタイミングの変更
  • フックポイントのパラメータの削除・データ型の変更
  • twigファイルに渡しているパラメータの削除・データ型の変更
  • Serviceクラスの公開関数の、引数の削除・データ型の変更
  • 入出力ファイル(CSVなど)のフォーマット変更

レビュワー確認項目

  • 動作確認
  • コードレビュー
  • E2E/Unit テスト確認(テストの追加・変更が必要かどうか)
  • 互換性が保持されているか
  • セキュリティ上の問題がないか

@chihiro-adachi chihiro-adachi added this to the 4.1 milestone Aug 31, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #5131 (343ae79) into 4.1 (ce55b43) will increase coverage by 0.01%.
The diff coverage is 7.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##              4.1    #5131      +/-   ##
==========================================
+ Coverage   68.16%   68.18%   +0.01%     
==========================================
  Files         457      455       -2     
  Lines       24988    24928      -60     
==========================================
- Hits        17034    16996      -38     
+ Misses       7954     7932      -22     
Flag Coverage Δ
tests 68.18% <7.69%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Controller/Admin/Content/MaintenanceController.php 50.00% <0.00%> (-1.43%) ⬇️
...rc/Eccube/EventListener/TwigInitializeListener.php 78.84% <0.00%> (+0.34%) ⬆️
src/Eccube/Repository/ProductRepository.php 96.93% <ø> (-0.08%) ⬇️
src/Eccube/Service/SystemService.php 44.23% <0.00%> (+1.80%) ⬆️
src/Eccube/Form/Type/Admin/SearchProductType.php 61.97% <100.00%> (+3.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce55b43...343ae79. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants