Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

管理者はメンテナンスモードを回避可能に変更 #5233

Merged
merged 9 commits into from
Jan 27, 2022

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Nov 25, 2021

概要(Overview・Refs Issue)

方針(Policy)

#4966 を参照

実装に関する補足(Appendix)

テスト(Test)

E2Eテストを追加

相談(Discussion)

マイナーバージョン互換性保持のための制限事項チェックリスト

  • 既存機能の仕様変更はありません
  • フックポイントの呼び出しタイミングの変更はありません
  • フックポイントのパラメータの削除・データ型の変更はありません
  • twigファイルに渡しているパラメータの削除・データ型の変更はありません
  • Serviceクラスの公開関数の、引数の削除・データ型の変更はありません
  • 入出力ファイル(CSVなど)のフォーマット変更はありません

レビュワー確認項目

  • 動作確認
  • コードレビュー
  • E2E/Unit テスト確認(テストの追加・変更が必要かどうか)
  • 互換性が保持されているか
  • セキュリティ上の問題がないか

@nanasess nanasess force-pushed the feature/traverse-maintenance branch 4 times, most recently from 3243651 to 745b2ed Compare November 25, 2021 07:01
@nanasess nanasess force-pushed the feature/traverse-maintenance branch from 745b2ed to a17039b Compare November 25, 2021 09:36
@codecov-commenter
Copy link

Codecov Report

Merging #5233 (9e84de7) into 4.1 (d99f4de) will increase coverage by 0.09%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##                4.1    #5233      +/-   ##
============================================
+ Coverage     68.33%   68.43%   +0.09%     
- Complexity     6069     6084      +15     
============================================
  Files           456      458       +2     
  Lines         24941    24983      +42     
============================================
+ Hits          17044    17096      +52     
+ Misses         7897     7887      -10     
Flag Coverage Δ
E2E 57.41% <81.81%> (+0.18%) ⬆️
Unit 76.04% <50.98%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/Eccube/EventListener/TwigInitializeListener.php 78.50% <50.00%> (-0.35%) ⬇️
src/Eccube/Service/SystemService.php 60.60% <73.91%> (+16.37%) ⬆️
src/Eccube/EventListener/MaintenanceListener.php 88.88% <88.88%> (ø)
...Controller/Admin/Content/MaintenanceController.php 74.28% <100.00%> (+24.28%) ⬆️
...Http/Authentication/EccubeLogoutSuccessHandler.php 100.00% <100.00%> (ø)
...be/Service/PurchaseFlow/Processor/TaxProcessor.php 70.49% <0.00%> (-3.28%) ⬇️
src/Eccube/Entity/TaxRule.php 86.41% <0.00%> (+1.23%) ⬆️
...orage/Handler/SameSiteNoneCompatSessionHandler.php 91.04% <0.00%> (+2.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d99f4de...9e84de7. Read the comment docs.

@chihiro-adachi chihiro-adachi added this to the 4.1.1 milestone Nov 29, 2021
@chihiro-adachi chihiro-adachi added the enhancement 機能追加 label Dec 1, 2021
@chihiro-adachi chihiro-adachi modified the milestones: 4.1.1, 4.1.x Dec 1, 2021
@matsuoshi matsuoshi modified the milestones: 4.1.x, 4.1.2 Jan 14, 2022
@carkn
Copy link
Contributor

carkn commented Jan 21, 2022

@nanasess
動作確認させていただきました。問題ないかと思います。

@chihiro-adachi
Copy link
Contributor

@chihiro-adachi
Copy link
Contributor

プラグインやキャッシュ削除時の自動メンテナンス化も動作問題ありませんでした。

@chihiro-adachi chihiro-adachi merged commit 4a202ca into EC-CUBE:4.1 Jan 27, 2022
@chihiro-adachi
Copy link
Contributor

@nanasess @izayoi256
ありがとうございます、マージしました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 機能追加
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants