implement ocean albedos for UFS #395

DeniseWorthen · 2023-07-27T14:47:23Z

Description of changes

Allow UFS to use the ocean albedo calculation in CMEPS. In order to implement in UFS several new config options were added. These are required to allow UFS to set non-standard albdir and albdif values and to set a minimum value of ocean albedo (required for consistency w/ FV3ATM). A new logical is also required to use the clock rather than the nextswCday scalar variable (UFS ATM component does not have this scalar value attached).

Includes minor UFS updates for

mapping type of WAV->ATM
using evaporative flux from ATM
ufs/ccpp modules

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)

no answer changes are expected for CESM

Any User Interface Changes (namelist or namelist defaults changes)?

Testing performed

Please describe the tests along with the target model and machine(s)
If possible, please also added hashes that were used in the testing

This changes answers for UFS, but also allows backward (non-b4b) ocean albedos to be used (when flux_ablav=.true., albdir=albdif=0.06). It has been tested and verified to provide a better estimate of net SW to the ocean in UFS.

* Corrected type for 2-m dewpoint. * Corrected type of variables diag_flux and diag_log. * Match von_karman_constant name with Physcons. --------- Co-authored-by: tanyasmirnova <[email protected]>

* remove swnet to ocean from custom_nems * set optional use of nextswday * get med history working w/o aofluxes

* flux_albav moved to _init * use_nextswcday for using clock instead of scalar field * min_albedo for setting min albedo used max(min_albedo,....) * giving a min_albedo value sets logical use_min_albedo, otherwise false and min_albedo=0 * set mean albdif and albdir via config. If not present, defaults to current values

* atm sends evap directly

DeniseWorthen · 2023-07-27T14:48:51Z

I marked this as draft to allow ESCOMP time to review and me to test any changes requested. Cheyenne is down next week, so I know testing for ESCOMP may be delayed.

mediator/med_io_mod.F90

mediator/med_phases_prep_ocn_mod.F90

mvertens

Thanks for this. I think the key thing is to test this within CESM to make sure that everything is bfb. Also - it would be good to not have the aoflux check also determine the ocnalb check - but that needs CESM testing to determine if that is okay.

mediator/med.F90

mediator/med_io_mod.F90

mvertens · 2023-07-30T20:49:42Z

mediator/med_phases_ocnalb_mod.F90

@@ -275,8 +329,9 @@ subroutine med_phases_ocnalb_run(gcomp, rc)

    ! Determine if ocnalb data type will be initialized - and if not return
    if (first_call) then
-       if ( ESMF_FieldBundleIsCreated(is_local%wrap%FBMed_aoflux_a, rc=rc) .and. &
-            ESMF_FieldBundleIsCreated(is_local%wrap%FBMed_aoflux_o, rc=rc)) then
+       if ((ESMF_FieldBundleIsCreated(is_local%wrap%FBMed_aoflux_a, rc=rc) .and. &


It would be good to test in CESM if we could also just use to check for ocnalb_o - and not for aoflux_a and aoflux_o - that would make this a lot more clean.

@mvertens I've made a change here (and below) to only check for FB_ocnalb_o, which I agree is much cleaner. I've tested it in two cases on our side, using ocnalb with and w/o aoflux and it works on our end. I do agree it needs testing to verify it won't break something for CESM.

mvertens · 2023-07-30T20:50:41Z

mediator/med_phases_ocnalb_mod.F90

@@ -430,18 +495,28 @@ subroutine med_phases_ocnalb_run(gcomp, rc)
       ofrad(:) = ofrac(:)
    endif

+    ! Write mediator ocnalb history if aofluxes are not active
+    if ( ESMF_FieldBundleIsCreated(is_local%wrap%FBMed_ocnalb_o, rc=rc) .and. &


Same comment as above in terms of just checking for ocnalb_o for CESM -and removing the check for aoflux_a and aoflux_o.

mvertens · 2023-07-31T09:05:43Z

mediator/med_phases_prep_ocn_mod.F90

@@ -529,8 +528,9 @@ subroutine med_phases_prep_ocn_custom_cesm(gcomp, rc)
             ifracr_scaled = ifracr(n) / (frac_sum)
             ofracr_scaled = ofracr(n) / (frac_sum)
          endif
-          Foxx_swnet(n) = ofracr_scaled*(fswabsv + fswabsi) + ifrac_scaled*Fioi_swpen(n)
-
+          if (.not.import_swpen_by_bands) then


Good catch. This should also be checked in testing.

DeniseWorthen · 2023-08-04T12:39:19Z

Cheyenne now back on line, so I'm opening the PR for CESM testing. Thanks!

jedwards4b · 2023-08-04T13:02:29Z

@DeniseWorthen I'm running cesm tests on cheyenne now. Can I push to your branch to fix the github test?

DeniseWorthen · 2023-08-04T14:27:38Z

@jedwards4b Yes, that would be fine.

jedwards4b · 2023-08-04T15:29:29Z

@DeniseWorthen

ERROR: Permission to DeniseWorthen/CMEPS.git denied to jedwards4b.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

DeniseWorthen · 2023-08-04T17:23:11Z

Sorry about that. I've added you now.

jedwards4b · 2023-08-04T21:00:38Z

I have a number of fully coupled and G tests failing. Here is an example:

run/ERI.T62_g37.G.cheyenne_intel.pop-cice.C.20230804_083150_9bhvwx.cice.h.0003-01-19.nc.base.cprnc.out:          of which      0 had non-zero differences
run/ERI.T62_g37.G.cheyenne_intel.pop-cice.C.20230804_083150_9bhvwx.cice.h.0003-01-19.nc.cprnc.out:          of which     87 had non-zero differences
run/ERI.T62_g37.G.cheyenne_intel.pop-cice.C.20230804_083150_9bhvwx.cpl.hi.0003-01-20-00000.nc.base.cprnc.out:          of which      0 had non-zero differences
run/ERI.T62_g37.G.cheyenne_intel.pop-cice.C.20230804_083150_9bhvwx.cpl.hi.0003-01-20-00000.nc.cprnc.out:          of which    104 had non-zero differences
run/ERI.T62_g37.G.cheyenne_intel.pop-cice.C.20230804_083150_9bhvwx.pop.h.0003-01-19.nc.base.cprnc.out:          of which      0 had non-zero differences
run/ERI.T62_g37.G.cheyenne_intel.pop-cice.C.20230804_083150_9bhvwx.pop.h.0003-01-19.nc.cprnc.out:          of which    109 had non-zero differences
run/ERI.T62_g37.G.cheyenne_intel.pop-cice.C.20230804_083150_9bhvwx.pop.hv.nc.base.cprnc.out:          of which      0 had non-zero differences
run/ERI.T62_g37.G.cheyenne_intel.pop-cice.C.20230804_083150_9bhvwx.pop.hv.nc.cprnc.out:          of which      0 had non-zero differences
run/ERI.T62_g37.G.cheyenne_intel.pop-cice.C.20230804_083150_9bhvwx.ww3.hi.0003-01-20-00000.nc.base.cprnc.out:          of which      0 had non-zero differences
run/ERI.T62_g37.G.cheyenne_intel.pop-cice.C.20230804_083150_9bhvwx.ww3.hi.0003-01-20-00000.nc.cprnc.out:          of which      3 had non-zero differences

DeniseWorthen · 2023-08-07T12:10:32Z

@jedwards4b I've reverted the change to swnet in prep_ocn (swnet is calculated regardless of whether import_by_bands is true or false). Could you please test again? Thanks.

jedwards4b · 2023-08-11T16:07:46Z

I did rerun a subset of tests and this did fix the problem. I'm sorry I forgot to let you know. @DeniseWorthen

DeniseWorthen · 2023-08-11T17:09:40Z

Thanks!

DeniseWorthen and others added 23 commits February 1, 2023 12:09

update CMEPS (NOAA-EMC#82)

4511994

add back bilnr_nstod mapping

cef1277

Modify CMEPS for ufsdev_ruclsm (NOAA-EMC#84)

91bcb84

* Corrected type for 2-m dewpoint. * Corrected type of variables diag_flux and diag_log. * Match von_karman_constant name with Physcons. --------- Co-authored-by: tanyasmirnova <[email protected]>

Merge branch 'NOAA-EMC:emc/develop' into feature/add_unstr

75fed2b

new clm lake variables (NOAA-EMC#77)

fe2c158

Merge remote-tracking branch 'ESCOMP/main' into feature/updcmeps

6776c24

Merge remote-tracking branch 'ESCOMP/main' into feature/updcmeps

66c0d0f

Merge remote-tracking branch 'ESCOMP/main' into feature/updcmeps

fd9151a

allow ufs to use check nan feature

ebc63bb

fix comments

a25075d

Merge remote-tracking branch 'ESCOMP/main' into feature/updcmeps

fd9872f

Merge remote-tracking branch 'ESCOMP/main' into feature/updcmeps

f568cfc

get ufs to work w/ ocnalb

6a642a6

* remove swnet to ocean from custom_nems * set optional use of nextswday * get med history working w/o aofluxes

Merge remote-tracking branch 'ESCOMP/main' into feature/updcmeps

a34f315

remove file accidentally committed

d75d75e

add config variables for ufs use case

a4d615e

Merge branch 'feature/updcmeps' into feature/fixsw

19042cf

Update CMEPS (NOAA-EMC#88)

cec8db8

Merge branch 'emc/develop' into feature/fixsw

acbddd2

use evap from atm (NOAA-EMC#96)

9923d6d

* atm sends evap directly

Merge branch 'NOAA-EMC:emc/develop' into feature/fixsw

5a3bd1c

remove TODOs

7b7d232

DeniseWorthen requested review from jedwards4b, uturuncoglu and mvertens July 27, 2023 14:47

jedwards4b requested changes Jul 27, 2023

View reviewed changes

mediator/med_io_mod.F90 Outdated Show resolved Hide resolved

mediator/med_phases_prep_ocn_mod.F90 Outdated Show resolved Hide resolved

DeniseWorthen added 2 commits July 27, 2023 11:39

use log_error, not log_info

4e09c3a

remove TODO

9bcf425

add missing return error check for FldsExchange

427ebeb

mvertens requested changes Jul 31, 2023

View reviewed changes

address comments

957a0fb

DeniseWorthen marked this pull request as ready for review August 4, 2023 12:38

Merge branch 'main' into feature/fixsw

f5894d4

revert changes for swnet in prep_ocn

ec41c2f

jedwards4b merged commit b751891 into ESCOMP:main Aug 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implement ocean albedos for UFS #395

implement ocean albedos for UFS #395

DeniseWorthen commented Jul 27, 2023 •

edited

Loading

DeniseWorthen commented Jul 27, 2023

mvertens left a comment

mvertens Jul 30, 2023

DeniseWorthen Jul 31, 2023

mvertens Jul 30, 2023

mvertens Jul 31, 2023

DeniseWorthen commented Aug 4, 2023

jedwards4b commented Aug 4, 2023

DeniseWorthen commented Aug 4, 2023

jedwards4b commented Aug 4, 2023

DeniseWorthen commented Aug 4, 2023

jedwards4b commented Aug 4, 2023

DeniseWorthen commented Aug 7, 2023

jedwards4b commented Aug 11, 2023

DeniseWorthen commented Aug 11, 2023

implement ocean albedos for UFS #395

implement ocean albedos for UFS #395

Conversation

DeniseWorthen commented Jul 27, 2023 • edited Loading

Description of changes

Specific notes

Testing performed

DeniseWorthen commented Jul 27, 2023

mvertens left a comment

Choose a reason for hiding this comment

mvertens Jul 30, 2023

Choose a reason for hiding this comment

DeniseWorthen Jul 31, 2023

Choose a reason for hiding this comment

mvertens Jul 30, 2023

Choose a reason for hiding this comment

mvertens Jul 31, 2023

Choose a reason for hiding this comment

DeniseWorthen commented Aug 4, 2023

jedwards4b commented Aug 4, 2023

DeniseWorthen commented Aug 4, 2023

jedwards4b commented Aug 4, 2023

DeniseWorthen commented Aug 4, 2023

jedwards4b commented Aug 4, 2023

DeniseWorthen commented Aug 7, 2023

jedwards4b commented Aug 11, 2023

DeniseWorthen commented Aug 11, 2023

DeniseWorthen commented Jul 27, 2023 •

edited

Loading