Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update everest-framework dependency to 0.13.0, bump version to 2024.4.0 #652

Merged

Conversation

hikinggrass
Copy link
Contributor

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

@hikinggrass
Copy link
Contributor Author

@golovasteek @dorezyuk @SirVer I ran
bazelisk run update //...
after updating the dependencies.yaml, which worked without any issues in #631 but now it seems to be failing, how do you properly update these dependencies for bazel?

@SirVer
Copy link
Contributor

SirVer commented Apr 26, 2024

mmh, the error is

Error in fail: error running 'git reset --hard v0.13.0' while working with @everest-framework:
fatal: ambiguous argument 'v0.13.0': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:

Which I do not understand, since the tag is clearly there. I ask @golovasteek to have a look at this, feel free to merge and we'll fix it in main or give us a day to look into it, your call @hikinggrass .

@golovasteek
Copy link
Contributor

@golovasteek @dorezyuk @SirVer I ran bazelisk run update //... after updating the dependencies.yaml, which worked without any issues in #631 but now it seems to be failing, how do you properly update these dependencies for bazel?

The issue is that bazel is strict with using tags or commits, we can not just swap the value. We need to tell if it is tag or commit.

I've changed framework dependency from commit to tag here: #653

I'll think about how to make it more generic (it should be somehow done automatically by bazel run //:update)

@hikinggrass hikinggrass merged commit f1ad5cc into main Apr 26, 2024
5 checks passed
@hikinggrass hikinggrass deleted the feature/update-everest-framework-bump-version-for-release branch April 26, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants