-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed websocketpp dependency. #631
Merged
hikinggrass
merged 8 commits into
main
from
enhancement/websocketpp_remove_dependencies
Apr 26, 2024
Merged
Removed websocketpp dependency. #631
hikinggrass
merged 8 commits into
main
from
enhancement/websocketpp_remove_dependencies
Apr 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
9dc782a
to
871d0c2
Compare
Signed-off-by: AssemblyJohn <[email protected]>
871d0c2
to
eb2cc98
Compare
Signed-off-by: AssemblyJohn <[email protected]>
0f2fdb7
to
0d2976c
Compare
Signed-off-by: Kai-Uwe Hermann <[email protected]>
…pp_remove_dependencies # Conflicts: # dependencies.yaml
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
hikinggrass
approved these changes
Apr 26, 2024
Signed-off-by: Kai-Uwe Hermann <[email protected]>
SirVer
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
golovasteek
approved these changes
Apr 26, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added the minimal websocket++ URI header in lib/3rd_party. Removed dependency to websocket++ library.
Issue ticket number and link
Linked to: EVerest/libocpp#568
Checklist before requesting a review