Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed websocketpp dependency. #631

Merged
merged 8 commits into from
Apr 26, 2024

Conversation

AssemblyJohn
Copy link
Contributor

@AssemblyJohn AssemblyJohn commented Apr 16, 2024

Describe your changes

Added the minimal websocket++ URI header in lib/3rd_party. Removed dependency to websocket++ library.

Issue ticket number and link

Linked to: EVerest/libocpp#568

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

@AssemblyJohn AssemblyJohn force-pushed the enhancement/websocketpp_remove_dependencies branch 4 times, most recently from 9dc782a to 871d0c2 Compare April 17, 2024 11:28
@AssemblyJohn AssemblyJohn force-pushed the enhancement/websocketpp_remove_dependencies branch from 871d0c2 to eb2cc98 Compare April 17, 2024 11:41
Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn AssemblyJohn force-pushed the enhancement/websocketpp_remove_dependencies branch from 0f2fdb7 to 0d2976c Compare April 17, 2024 12:31
Copy link
Contributor

@SirVer SirVer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@hikinggrass hikinggrass merged commit d888a88 into main Apr 26, 2024
5 checks passed
@hikinggrass hikinggrass deleted the enhancement/websocketpp_remove_dependencies branch April 26, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants