Removed dependency on websocket++, minimized dependencies #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AssemblyJohn
requested review from
Pietfried,
hikinggrass,
marcemmers and
maaikez
as code owners
AssemblyJohn
force-pushed
the
enhancement/websocketpp_remove_dependencies
branch
3 times, most recently
from
4435b41 to
2a0e47b
Compare
Pietfried
requested changes
Apr 16, 2024
AssemblyJohn
force-pushed
the
enhancement/websocketpp_remove_dependencies
branch
2 times, most recently
from
971c7e5 to
e84f740
Compare
|
Implemented comments. Some codacity issues are related to some 3rd _party code I wouldn't modify too much. This can't be merged with the required modifications in everest-core. |
Pietfried
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
looks good from my side. Please wait for @hikinggrass approval as well before merging
3 tasks
|
I'd also require a review on: EVerest/everest-core#631 This can't be merged without that. |
AssemblyJohn
force-pushed
the
enhancement/websocketpp_remove_dependencies
branch
3 times, most recently
from
08f9d4a to
ddf79b6
Compare
hikinggrass
requested changes
Apr 17, 2024
AssemblyJohn
force-pushed
the
enhancement/websocketpp_remove_dependencies
branch
2 times, most recently
from
bd52eea to
0832365
Compare
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
AssemblyJohn
force-pushed
the
enhancement/websocketpp_remove_dependencies
branch
2 times, most recently
from
0f8f8ed to
ba20ea2
Compare
Signed-off-by: AssemblyJohn <[email protected]>
AssemblyJohn
force-pushed
the
enhancement/websocketpp_remove_dependencies
branch
from
ba20ea2 to
a1bb4b7
Compare
Pietfried
approved these changes
Apr 25, 2024
…pp_remove_dependencies # Conflicts: # lib/ocpp/common/websocket/websocket_libwebsockets.cpp
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
…pp_remove_dependencies
hikinggrass
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Removed the strong dependency to websocket++ by adding the relevant headers to a 3rd_party folder, and making the library optional based on a cmake option. The hard-coded websocket++ constants were also removed.
Issue ticket number and link
Linked core PR: EVerest/everest-core#631
Checklist before requesting a review