Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add conv zoom button #4

Open
wants to merge 758 commits into
base: master
Choose a base branch
from
Open

Conversation

EdAyers
Copy link
Owner

@EdAyers EdAyers commented Jun 28, 2022

No description provided.

Copy link
Owner Author

@EdAyers EdAyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KaseQuark here's a review of your code 🙂


open Except in
/-- Get the raw subexpression withotu performing any instantiation. -/
private def viewCoordRaw: Nat → Expr → Except String Expr
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now in core

| c, e => error s!"Bad coordinate {c} for {e}"

/-- Decodes a subexpression `Pos` as a sequence of coordinates. See `Pos.encode` for details.-/
private def decode (p : Nat) : Array Nat :=
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also in core

return { expr := retexpr, val? := toString ((listParam.head!) + 1), listRest := listParam.tail! , test := "generic\n" }

def buildConvZoomCommands (subexprParam : SubexprInfo) (goalParam : InteractiveGoal) : MetaM (ConvZoomCommands) := do
let mut ret := "/-\n"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please indent decl bodies

deriving Inhabited

private def solveLevel (expr : Expr) (listParam : List Nat) : MetaM (SolveReturn) := match expr with
| e@(Expr.app _ _ _) => do
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent


structure ConvZoomCommands where
commands? : Option String
deriving RpcEncoding
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use deriving ToJson, FromJson

leodemoura and others added 30 commits October 9, 2022 17:45
…ments that have been inferred when applying congr theorem

see leanprover#1711
TODO: improve support for instance implicit arguments at `congr`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants