fix(debug): don't initalise SP_AUX1 if not exist #4962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3djc
approved these changes
May 3, 2024
It is a CMake option, so belongs in CMakeLists.txt for the relevant target
|
Thanks JC, and glad I fixed a bug before it bugged you 😁 NV14 and PL18EV are both working now - could toggle debug output on USB-VCP. I have just sanity checked on TX16S... AUX1 is still putting out debug output until otherwise instructed, and you can disable it and switch to USB-VCP (because both ports are configurable). This should generally only effect the NV14/EL18/PL18/PL18EV and X10 Express as standard. I do see a bunch of TARANIS targets don't enable AUX_SERIAL by defaults as it it not turned on across the board as it is with horus targets, but that means they need their options updated if anything is missing there. |
|
I will review the aux serial definitions for Taranis, but it certainly cannot be defined across the board(s) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4958
Summary of changes:
#3814 implicitly exposed an assumption whereby AUX1 was being initialised for use for debugging when not available, and thus locking "Debug" out as an option for USB-VCP on radios with no available AUX1. Therefore, check if AUX_SERIAL is defined as well as DEBUG.