DynaFed note for con_max_block_sig_size #155
Conversation
Included a note that the signature size constant under DynaFed is 77, rather than 74 prior to DynaFed. The formula for con_max_block_sig_size is affected. The guide doesnt yet use DynaFed so this may not be the most appropriate place for this note, feel free to reject it and put in a more appropriate location.
|
Thanks @opacey - I will check with the elements team who did Dyna fed and merge when I've had this confirmed. Thanks for the Pull Request and drawing attention to it. |
|
Where did you get the 77 from? |
|
Only from a process of trial and error. 77 seems to work in place of 74 in the pre-dynafed formula when applied to custom chains. Smaller values cause errors, and larger dont - this was the smallest which worked so I assume it is correct. However perhaps the formula itself is now different and it is only coincidence that 77 lands on a big enough final value. Sorry, should have been more clear in the original comment that this was speculation. |
|
@stevenroose - is this ok to merge after the conversation above or is there a set formula that derives the figure? |
Included a note that the signature size constant under DynaFed is 77, rather than 74 prior to DynaFed. The formula for con_max_block_sig_size is affected. The guide doesnt yet use DynaFed so this may not be the most appropriate place for this note, feel free to reject it and put in a more appropriate location.