Remove deprecated things for next release #4902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
guilt/remove-deprecated
branch
from
e327757 to
d48ef07
Compare
vincenzopalazzo
approved these changes
Nov 4, 2021
There was a problem hiding this comment.
LGTM d48ef07
Seems only that there is some python test related to the onion addr
rustyrussell
force-pushed
the
guilt/remove-deprecated
branch
from
d48ef07 to
3dd0860
Compare
rustyrussell
force-pushed
the
guilt/remove-deprecated
branch
from
3dd0860 to
fcfe521
Compare
Merged
We're about to require that fundchannel_complete() take a PSBT, where it does sanity checks to avoid this error, making this a difficult mistake to make. Is it time to remove this functionality anyway? @cdecker? Signed-off-by: Rusty Russell <[email protected]>
Changelog-Removed: JSON-RPC: `fundchannel_complete` `txid` and `txout` parameters (deprecated in v0.10.0)
Changelog-Removed: Plugins: The `message` field on the `custommsg` hook (deprecated in v0.10.0)
October was the date Torv2 is no longer supported by the Tor Project; it will probably not work at all by next release, so we should remove it now even though it's not quite the 6 months we prefer for deprecation cycles. I still see 110 nodes advertizing Torv2 (vs 10,292 Torv3); we still parse and display it, we just don't advertize or connect to it. Signed-off-by: Rusty Russell <[email protected]>
And switch ```` to ``` (emacs colorization was confused!). Signed-off-by: Rusty Russell <[email protected]>
autotor is older, but statictor is better. Your options are really "use HiddenServiceDir in torrc" vs "use statictor", with the issue that statictor requires you to configure Tor for control access by c-lightning. Signed-off-by: Rusty Russell <[email protected]>
This surprised me, since the CHANGELOG for [0.8.2] said: We now announce multiple addresses of the same type, if given. ([3609](ElementsProject#3609)) But it lied! Changelog-Fixed: We really do allow providing multiple addresses of the same type. Signed-off-by: Rusty Russell <[email protected]>
blob[] is really a string from the commandline; leave it as a char. And parsing is much simpler than this code makes it seem! Signed-off-by: Rusty Russell <[email protected]>
…can's. Signed-off-by: Rusty Russell <[email protected]>
For consistency. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/remove-deprecated
branch
from
fcfe521 to
99cf8ba
Compare
Comment on lines
-229
to
-246
| /* gossipd will refuse to announce the second one, sure, but it's | ||
| * better to check and fail now if they've explicitly asked for it. */ | ||
| wn = &ld->proposed_wireaddr[n].u.wireaddr; | ||
| for (size_t i = 0; i < n; i++) { | ||
| const struct wireaddr *wi; | ||
|
|
||
| if (ld->proposed_listen_announce[i] != ADDR_ANNOUNCE) | ||
| continue; | ||
| assert(ld->proposed_wireaddr[i].itype == ADDR_INTERNAL_WIREADDR); | ||
| wi = &ld->proposed_wireaddr[i].u.wireaddr; | ||
|
|
||
| if (wn->type != wi->type) | ||
| continue; | ||
| return tal_fmt(NULL, "Cannot announce address %s;" | ||
| " already have %s which is the same type", | ||
| type_to_string(tmpctx, struct wireaddr, wn), | ||
| type_to_string(tmpctx, struct wireaddr, wi)); | ||
| } |
There was a problem hiding this comment.
I'm missing why we are removing this one?
There was a problem hiding this comment.
Because it is just preventing the user from doing something he must have done consciously. If the user gives multiple addresses he most likely has a reason for it and since it is allowed from the protocol spec, why prevent that?
There was a problem hiding this comment.
Yes, it used to be forbidden, but spec was updated to allow it (and other implementations allowed it).
There was a problem hiding this comment.
Ah, got it :) thanks and sorry for the missing
CI seems to be OOM killing us; 5 may be too many under valgrind. VALGRIND=1 pytest tests/test_pay.py::test_fetchinvoice Before: 1 passed in 199.33s (0:03:19) After: 1 passed in 177.91s (0:02:57) Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/remove-deprecated
branch
from
a4c41a0 to
3e49e08
Compare
This loads up 20MB of plugins temporarily; we seem to be getting OOM killed under CI and I wonder if this is contributing. Doesn't significantly reduce runtime here, but I have lots of memory. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/remove-deprecated
branch
from
3e49e08 to
8d0d4dc
Compare
|
ACK 8d0d4dc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also reworked TOR.md for more clarity (since we remove v2).