Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization #14

Merged
merged 11 commits into from
May 31, 2023
Merged

Localization #14

merged 11 commits into from
May 31, 2023

Conversation

WarningImHack3r
Copy link
Member

@WarningImHack3r WarningImHack3r commented May 24, 2023

Add localization with Inlang, because we're lacking SvelteKit's native mechanism and that Inlang is (will be?) great.

Features

  • Translation of texts, but also aria-* stuff and alt/accessibility props
  • Dedicated JSON files
  • Footer toggle, reflecting the current applied language, to switch between both
  • Storage of current or overridden language in localStorage
  • Instant switch without reload

Bonus

  • (Yet another) CI step to check for updates of sdk-js inside of inlang.config.js and update if the version is not the same as the one installed with pnpm
    • Add JS script & package.json script for that
  • Add c function in $ts/inlang-color.ts to replace [] by <span class="text-dominant"></span> with Svelte's {@html ...} (customizable class)
  • Make RadioButtonsGroup values mandatory and add optional hoverValues to change the value on hover
  • Adjust the footer Solutions list to match recent changes

Left to do

  • Don't require page refresh for nested keys in objects

@WarningImHack3r WarningImHack3r changed the title Localization! Localization May 24, 2023
@WarningImHack3r WarningImHack3r added the enhancement New feature or request label May 24, 2023
@WarningImHack3r WarningImHack3r marked this pull request as ready for review May 26, 2023 13:38
@WarningImHack3r WarningImHack3r requested a review from MinixBF May 26, 2023 13:38
@MinixBF MinixBF merged commit 53c955e into main May 31, 2023
@MinixBF MinixBF deleted the localization branch May 31, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants