Merge pull request #215 from Belchy06/issue-203

Fix: Reconnects will be attempted even when a disconnect is triggered by afk timeout
EpicGames · May 3, 2023 · 79a1de6 · 79a1de6
2 parents 28d079d + b6b26a0
commit 79a1de6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/Frontend/library/src/PixelStreaming/PixelStreaming.test.ts b/Frontend/library/src/PixelStreaming/PixelStreaming.test.ts
@@ -209,7 +209,7 @@ describe('PixelStreaming', () => {
         expect(webSocketSpyFunctions.constructorSpy).toHaveBeenCalledTimes(1);
         expect(webSocketSpyFunctions.closeSpy).not.toHaveBeenCalled();
 
-        pixelStreaming.disconnect();
+        pixelStreaming.webSocketController.close();
 
         expect(webSocketSpyFunctions.closeSpy).toHaveBeenCalled();
 

diff --git a/Frontend/library/src/PixelStreaming/PixelStreaming.ts b/Frontend/library/src/PixelStreaming/PixelStreaming.ts
@@ -42,8 +42,8 @@ export interface PixelStreamingOverrides {
  * this will likely be the core of your Pixel Streaming experience in terms of functionality.
  */
 export class PixelStreaming {
-    private _webRtcController: WebRtcPlayerController;
-    private _webXrController: WebXRController;
+    protected _webRtcController: WebRtcPlayerController;
+    protected _webXrController: WebXRController;
     /**
      * Configuration object. You can read or modify config through this object. Whenever
      * the configuration is changed, the library will emit a `settingsChanged` event.

diff --git a/Frontend/library/src/WebRtcPlayer/WebRtcPlayerController.ts b/Frontend/library/src/WebRtcPlayer/WebRtcPlayerController.ts
@@ -1589,6 +1589,8 @@ export class WebRtcPlayerController {
      * Close the Connection to the signaling server
      */
     closeSignalingServer() {
+        // We explicitly called close, therefore we don't want to trigger auto reconnect
+        this.shouldReconnect = false;
         this.webSocketController?.close();
     }