This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Fix: Reconnects will be attempted even when a disconnect is triggered by afk timeout #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…private. This allows users to extend the base PixelStreaming class and access these member
mcottontensor
approved these changes
May 3, 2023
|
Looks good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
This PR addresses #203.
Solution
When programmatically closing the websocket connection, we set the
shouldReconnectbool to false, indicating that the webRtcPlayerController should no attempt to auto reconnect.Documentation
No updates needed.
Test Plan and Compatibility
Testing completed by triggering a stream restart on the frontend and observed the auto reconnect functionality not being triggered.
Also triggered the reconnect flow and observed it still worked as expected.