-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(WIP) Display experiment progress bar in nav bar and database page #1075
Closed
notoraptor
wants to merge
22
commits into
Epistimio:develop
from
notoraptor:experiment-progress-bar-dashboard
Closed
(WIP) Display experiment progress bar in nav bar and database page #1075
notoraptor
wants to merge
22
commits into
Epistimio:develop
from
notoraptor:experiment-progress-bar-dashboard
+3,330
−2,034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bb042f5.
…ard SRC tests, as they won't currently pass.
3a33454
to
d53c6e7
Compare
- Serve built dashboard in background - pre-commit failed with error `[extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'` - Try to solve by bumping isort version: home-assistant/core#86892 (comment)
…s (waitFor() does not seem to work when waiting for multiple elements)
Move nav bar scrolling test into nav bar tests file
Fix experimentrs visualizations tests and add them to CI
Close for now, as PR #1078 should be merged first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi @bouthilx ! This is my pull request to add experiment progress bar in dashboard. It's still in WIP because I am currently not able to write unit tests, so it can not yet be merged.
Changes
TODO:
I am not able to write unit tests for now: Jest module (used to test dashboard source) allows to render components, but it does not seem to simulate component sizes, so that components don't have size, thus I can't test scrolling on nav bar. I am still looking for a solution, but it seems pretty hard.
Checklist
Tests
$ tox -e py38
; replace38
by your Python version if necessary)Documentation
Quality
$ tox -e lint
)Further comments
Still work in progress, cannot yet be merged