Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Display experiment progress bar in nav bar and database page #1075

Conversation

notoraptor
Copy link
Collaborator

Description

Hi @bouthilx ! This is my pull request to add experiment progress bar in dashboard. It's still in WIP because I am currently not able to write unit tests, so it can not yet be merged.

Changes

  • Display a small progress bar near experiment names in nav bar
  • Display a full clickable progress bar with supplementary experiment stats and into above trials table in database page
  • Set infinite scroll on nav bar to load small progress bars progressively
  • Add supplementary experiments in test database to cover corner cases related to experiment stats (especially about max_trials values)

TODO:

I am not able to write unit tests for now: Jest module (used to test dashboard source) allows to render components, but it does not seem to simulate component sizes, so that components don't have size, thus I can't test scrolling on nav bar. I am still looking for a solution, but it seems pretty hard.

Checklist

Tests

  • I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • I have updated the relevant documentation related to my changes

Quality

  • I have read the CONTRIBUTING doc
  • My commits messages follow this format
  • My code follows the style guidelines ($ tox -e lint)

Further comments

Still work in progress, cannot yet be merged

Sorry, something went wrong.

@notoraptor notoraptor force-pushed the experiment-progress-bar-dashboard branch from 3a33454 to d53c6e7 Compare January 30, 2023 16:10
- Serve built dashboard in background
- pre-commit failed with error `[extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'`
  - Try to solve by bumping isort version: home-assistant/core#86892 (comment)
- do not retry playwright tests
- bounding boxes values aren't all stable.
…s (waitFor() does not seem to work when waiting for multiple elements)
- remove upload-artifact
- fix 2 more test files work with playwright
Move nav bar scrolling test into nav bar tests file
Fix experimentrs visualizations tests and add them to CI
- Set up database with additional uncompleted experiments
- Use new database for unit tests
@notoraptor
Copy link
Collaborator Author

Close for now, as PR #1078 should be merged first.

@notoraptor notoraptor closed this Feb 1, 2023
@notoraptor notoraptor deleted the experiment-progress-bar-dashboard branch February 7, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant