-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard - new testing framework: playwright #1078
Merged
bouthilx
merged 24 commits into
Epistimio:develop
from
notoraptor:dashboard-new-testing-framework
Feb 3, 2023
Merged
Dashboard - new testing framework: playwright #1078
bouthilx
merged 24 commits into
Epistimio:develop
from
notoraptor:dashboard-new-testing-framework
Feb 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
notoraptor
changed the title
[Dashboard] new testing framework: playwright
Dashboard - new testing framework: playwright
Feb 1, 2023
bouthilx
reviewed
Feb 1, 2023
bouthilx
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I relaunched the tests. I don't understand how the current failures would relate to the current changes in this PR.
I relaunched failing tests (test-long-algo). |
This reverts commit bb042f5.
…ard SRC tests, as they won't currently pass.
…s (waitFor() does not seem to work when waiting for multiple elements)
Move nav bar scrolling test into nav bar tests file
Fix experimentrs visualizations tests and add them to CI
Keep everything else, including infinite scroll
notoraptor
force-pushed
the
dashboard-new-testing-framework
branch
from
February 2, 2023 20:20
b822d75
to
bf3a8c5
Compare
Rebased! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi @bouthilx ! This is a PR that adds all changes related to unit tests, excluding changes related to experiment progress bar.
As this work was done to be able to test infinite scroll, I kept infinite scrolling feature added in this PR.
This PR replaces old dashboard testing framework React testing library with a new framework Playwright which uses a real browser in backend, allowing to make more complex tests, especially tests that needs HTML components with real dimensions. This is particularly necessary to test how a component reacts to a scrolling.
Changes
dashboard/src/src/__tests__/ExperimentNavBar.test.js
Checklist
Tests
$ tox -e py38
; replace38
by your Python version if necessary)Documentation
Quality
$ tox -e lint
)