Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MemberExpression's property field is typed as an Expression, but can be false #256

Closed
benoitkoenig opened this issue Oct 17, 2023 · 1 comment · Fixed by #262
Closed

MemberExpression's property field is typed as an Expression, but can be false #256

benoitkoenig opened this issue Oct 17, 2023 · 1 comment · Fixed by #262
Labels
released

Comments

@benoitkoenig
Copy link

Parsing the expression [1, 2, 3][] returns a MemberExpression

  • It's object field contains the expression for the array [1, 2, 3] as expected
  • It's property field is set to false. MemberExpression#property is typed as an Expression and cannot be false

I made a minimal repro repository here

Please either update MemberExpression's type, or update it's return value when meeting this specific scenario
6utt3rfly added a commit that referenced this issue Jul 6, 2024
@6utt3rfly
fix: detect unexpected ] in expression "[1,2][]"
70b8ea6 
fixes #256
@6utt3rfly 6utt3rfly mentioned this issue Jul 6, 2024
Merged
github-actions bot pushed a commit that referenced this issue Jul 12, 2024
@semantic-release-bot
build: 1.3.9 [skip ci]
0497757 
## [1.3.9](v1.3.8...v1.3.9) (2024-07-12)

### Bug Fixes

* add types add/remove/removeAll functions ([b4a5b1a](b4a5b1a)), closes [#238](#238)
* add types for SequenceExpressions ([d0cf015](d0cf015)), closes [#261](#261)
* detect unexpected ] in expression "[1,2][]" ([70b8ea6](70b8ea6)), closes [#256](#256)
* do not access prototype ([037d1db](037d1db)), closes [#239](#239)
* throwError return type ([e0df539](e0df539)), closes [#252](#252)
* update Array elements typing ([097ae12](097ae12))
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.3.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix types, cleanup minor submitted PRs & issues EricSmekens/jsep
1 participant
@benoitkoenig