Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing typings for SequenceExpression #261

Closed
Pikachews opened this issue Jun 4, 2024 · 1 comment · Fixed by #262
Closed

Missing typings for SequenceExpression #261

Pikachews opened this issue Jun 4, 2024 · 1 comment · Fixed by #262
Labels
released

Comments

@Pikachews
Copy link

SequenceExpression appears to be used here:

jsep/src/jsep.js

Lines 855 to 858 in 72e0458

return {
type: Jsep.SEQUENCE_EXP,
expressions: nodes,
};

but no typings exist for it in https://github.com/EricSmekens/jsep/blob/72e045878a8237f30184cc7d6ae3f0dcd58a4ef5/typings/tsd.d.ts.
@6utt3rfly 6utt3rfly mentioned this issue Jul 6, 2024
Merged
github-actions bot pushed a commit that referenced this issue Jul 12, 2024
@semantic-release-bot
build: 1.3.9 [skip ci]
0497757 
## [1.3.9](v1.3.8...v1.3.9) (2024-07-12)

### Bug Fixes

* add types add/remove/removeAll functions ([b4a5b1a](b4a5b1a)), closes [#238](#238)
* add types for SequenceExpressions ([d0cf015](d0cf015)), closes [#261](#261)
* detect unexpected ] in expression "[1,2][]" ([70b8ea6](70b8ea6)), closes [#256](#256)
* do not access prototype ([037d1db](037d1db)), closes [#239](#239)
* throwError return type ([e0df539](e0df539)), closes [#252](#252)
* update Array elements typing ([097ae12](097ae12))
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.3.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix types, cleanup minor submitted PRs & issues EricSmekens/jsep
1 participant
@Pikachews