Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed calendar emoji and replaced with blue calendar SVG #469

Merged
merged 2 commits into from
May 15, 2022
Merged

Conversation

karnikaavelumani
Copy link
Collaborator

Replaced calendar emoji with blue calendar SVG. The blue calendar was made using Figma so that the color could be matched to the acmBlue. The calendar will be hidden when the size of the screen decreases to a significant amount.

Mode Before After
Light image image
Dark image image

Fixed #467

@karnikaavelumani karnikaavelumani added the bugfix A PR that fixes a bug label May 15, 2022
@vercel
Copy link

vercel bot commented May 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
acm-csuf-site ✅ Ready (Inspect) Visit Preview May 15, 2022 at 5:38AM (UTC)

Updated size of calendar SVG on events page to fit accordingly to emoji size.
@vercel vercel bot temporarily deployed to Preview May 15, 2022 05:38 Inactive
@karnikaavelumani
Copy link
Collaborator Author

Changed size to make it smaller as according to @jaasonw

@jaasonw
Copy link
Contributor

jaasonw commented May 15, 2022

works ofr me : )

@jaasonw jaasonw merged commit 486a2ec into main May 15, 2022
<h2 class="size-lg headers">Upcoming Events 📅</h2>
<div class="main-header">
<h2 class="size-lg headers">Upcoming Events</h2>
<img src="assets/bluecalender.svg" alt="Blue Calender" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jk can u add a / in front of this and then re pull request LOL

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think it's the most important thing to have but it's tehcnically correct idk thoughts? @EthanThatOneKid

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think it's the most important thing to have but it's tehcnically correct idk thoughts? @EthanThatOneKid

Since we will add the / in the last PR, we should probably add the / in this PR as well.

jk can u add a / in front of this and then re pull request LOL

A quick follow-up PR sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix A PR that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use blue calendar SVG instead of 📅
3 participants