Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Blog Header For Dark Mode Compatibility #468

Merged
merged 3 commits into from
Jun 2, 2022
Merged

Updated Blog Header For Dark Mode Compatibility #468

merged 3 commits into from
Jun 2, 2022

Conversation

karnikaavelumani
Copy link
Collaborator

@karnikaavelumani karnikaavelumani commented May 14, 2022

Converted previous SVG image into a responsive segment of HTML that is better suited for the website and dark mode compatibility.

Mode Desktop (Light) Desktop (Dark) Phone (Light) Phone (Dark)
Before image image image image
After image image image image

Fixed #430

@karnikaavelumani karnikaavelumani added the bugfix A PR that fixes a bug label May 14, 2022
@vercel
Copy link

vercel bot commented May 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
acm-csuf-site ✅ Ready (Inspect) Visit Preview Jun 2, 2022 at 10:02PM (UTC)

@karnikaavelumani karnikaavelumani changed the title Fix/430 Updated Blog Header For Dark Mode Compatibility May 14, 2022
@jaasonw
Copy link
Contributor

jaasonw commented May 15, 2022

umm, where is the blog?

2022-05-15.03-18-53.mp4

@vercel vercel bot temporarily deployed to Preview May 15, 2022 17:16 Inactive
@karnikaavelumani
Copy link
Collaborator Author

I'm not sure what happened to the blog but it's not working at all until you refresh it

@jaasonw
Copy link
Contributor

jaasonw commented May 15, 2022

it became a 404 after i refreshed it

@EthanThatOneKid
Copy link
Owner

EthanThatOneKid commented May 15, 2022

umm, where is the blog?

2022-05-15.03-18-53.mp4

I'm not sure what happened to the blog but it's not working at all until you refresh it

it became a 404 after i refreshed it

I suspect our serverless function throws an error when it attempts to read from a JSON file since Vercel.com currently says, "At present, it is not possible to import files in a Next.js SSR page or function given vercel/next.js#8251." This lead me to create issue #471.

By eliminating the following line of code, the blog just might [hopefully] start to work again in preview environments!

const SAMPLE_POSTS = readFileSync('./src/routes/blog/_testdata/posts.json');

^ I suspect this line of code may be our problem, so I made #472 in an attempt to resolve #471.

@vercel vercel bot temporarily deployed to Preview May 15, 2022 22:09 Inactive
src/routes/blog/index.svelte Show resolved Hide resolved
src/routes/blog/index.svelte Show resolved Hide resolved
src/routes/blog/index.svelte Show resolved Hide resolved
@jaasonw
Copy link
Contributor

jaasonw commented May 24, 2022

Closing because I merged these changes into #481

@jaasonw jaasonw closed this May 24, 2022
@jaasonw jaasonw reopened this May 26, 2022
@vercel vercel bot temporarily deployed to Preview June 2, 2022 22:02 Inactive
@jaasonw jaasonw merged commit ceec2d6 into main Jun 2, 2022
@jaasonw jaasonw deleted the fix/430 branch June 6, 2022 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix A PR that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blog logo unreadable when in dark mode
3 participants