[HOLD for payment 2023-07-26] [$250] Migrate AddDebitCardPage.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/pages/settings/Payments/AddDebitCardPage.js
  • type: React.Component
  • has state values: false
  • has refs: false
  • has context: false
  • lifecycle methods: componentWillUnmount,componentDidUpdate

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012d6b3b0bf0cd8a57
• Upwork Job ID: 1673399016680251392
• Last Price Increase: 2023-06-26

[MelvinBot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[marcaaron]

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

[multijump]

I can work on this if goes to external

[muxriddinmuqimov77]

I'd like to work on this issue when it goes to external

[melvin-bot]

Triggered auto assignment to @alexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012d6b3b0bf0cd8a57

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[neonbhai]

I would love to work on this!
(first comment after going external😅)

[olexyt]

I would like to work on this.

[rayane-d]

can I work on this?

[Santhosh-Sellavel]

Since the @multijump & @muxriddinmuqimov77 have an existing migration issue open let's go with @neonbhai

C+ Reviewed
🎀 👀 🎀

[Christinadobrzyn]

I'm going to be ooo until July 31st so going to unassign and assign a new teammate.

@michaelhaxhiu At this time, we're reviewing the PR and waiting for payment #16284 (comment)

I'll take this back when I return if it's still open

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @yh-0218 got assigned: 2023-06-30 18:57:39 Z
• when the PR got merged: 2023-07-17 21:40:41 UTC
• days elapsed: 11

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.42-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• migrate AddDebitCardPage to function component #16284 #22154

If no regressions arise, payment will be issued on 2023-07-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@michaelhaxhiu / @Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Santhosh-Sellavel]

We can skip the checklist as this is not a bug!

[Santhosh-Sellavel]

Requested $250 on ND!

[michaelhaxhiu]

Payment summary:

• @yh-0218 $250 as contributor via Upwork
• @Santhosh-Sellavel $250 as C+ via newDot

[michaelhaxhiu]

all paid

[JmillsExpensify]

Reviewed details for @Santhosh-Sellavel. This is accurate and approved for payment in NewDot.