[Pay 8/27] Long pressing on iOS shows native menu instead of action menu

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open app in iOS
2. Navigate to a conversation
3. Long press on a message

Expected Result:

App action menu should be displayed.

Actual Result:

Native iOS menu is displayed.

Workaround:

User has to press on a specific place in the message to trigger the action menu.

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.0.79-4

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

View all open jobs on Upwork

---

From @JmillsExpensify https://expensify.slack.com/archives/C01GTK53T8Q/p1626826264051300

Long press is broken again on iOS 1.0.79-1. Pulls up the native copy action rather than the comment action menu.

Upwork job: https://www.upwork.com/jobs/~011723749fa516e7c9

[MelvinBot]

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

@Gonals Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

@Gonals Huh... This is 4 days overdue. Who can take care of this?

[MelvinBot]

@Gonals Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[MelvinBot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[Gonals]

Good candidate for external!

[puneetlath]

Job created: https://www.upwork.com/jobs/~011723749fa516e7c9

[arpitdeveloper]

In this case I add a actionSheet or alert in app action on long press the message in "main/src/pages/home/report/ReportActionItem.js"

[parasharrajat]

Proposal

1. We are using canUseTouchScreen to manage the text selection which controls the Copy native menu.
2. This is really meant for Web devices so its usages for Native devices is wrong which gives false.
3. But we have to use this to control selection on the Mobile Web. That's why we can noop this function on native devices which returns true as all of the native devices will always have touch (based on the code architecture we have so far in the app).

we can create a index.native.js for canUseTouchScreen

export default () => true;

It will fix this issue.

[RushirajJhala]

Hi @parasharrajat
this will solve issue of long press in message, but long press on username still shows native menu.

[MelvinBot]

@puneetlath Whoops! This issue is 2 days overdue. Let's get this updated quick!

[parasharrajat]

I feel like this is urgent and causes a bad UX for native users. @puneetlath Any thoughts?

this will solve issue of long press in message, but long press on username still shows native menu.

It opens the details page of the user, not the contextMenu. ContextMenu is set up for messages but not for users avatars.

[MelvinBot]

@puneetlath Eep! 4 days overdue now. Issues have feelings too...

[parasharrajat]

@puneetlath This can be quickly solved. The proposal here #4200 (comment).

[MelvinBot]

@puneetlath 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[puneetlath]

@parasharrajat sorry for the delay. Let's go ahead with your solution.

[parasharrajat]

I am curious if this job needs to be doubled as no one was hired for 11 days. cc: @mallenexpensify

[mallenexpensify]

@parasharrajat That's a tough one. The purpose of doubling prices is to encourage contributors to submit proposals and fixes. If that doesn't happen in a week we then double until we find a proposal we approve.

The issue here is two fold.

1. There will be times when there are internal priorities that delay our contributor process. They should be rare but we happen to have one of those going on now which was addressed last week here
2. You helped uncover a potential bottleneck in our process. Puneet is both a Contributor Manager (CM) and Contributor Manager Engineer (CME). Because of this, he became the single assignee on an issue because he's on both teams so our bot didn't assign a new CME when he assigned the Exported label.

Based on the above, I don't think this qualifies for 'double price'. Related, in the near future, there should be an automated 'double price' issue comment that will help regulate this (but it's more of a guide than a set-in-stone rule).

It looks like we're awaiting your acceptance for the job here https://www.upwork.com/jobs/~011723749fa516e7c9

[parasharrajat]

Thanks for clarifying and taking the time to answer it. I have accepted the offer. Thanks.

[mallenexpensify]

@puneetlath will review your PR once submitted, I've added myself as an assignee as a CM so I'll handle payment once completed.

[mallenexpensify]

Will pay on Friday, would like this to get to staging for testing/review

[mallenexpensify]

Forgot to pay on Friday, apologies @parasharrajat , paid just now in Upwork