-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix context-menu on native devices #4687
Conversation
Any thought @puneetlath? |
@Beamanator Could you please review this? I will upload the screens for other platforms if needed. |
@parasharrajat we'd like everyone to be in the habit of testing all PRs on every platform so in the future, please do add a screenshot for every platform. This is how we'll most effectively reduce regressions |
I did test it but didn't upload the images. I will update them. |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested on android, ios, mweb safari -> works great 👍
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀
|
This has been deployed to production and is now subject to a 7-day regression period. |
Details
Fixed Issues
$ #4200
Tests | QA Steps
Tested On
Screenshots
Web | Desktop
Mobile Web
iOS
context-menu.mp4
Android