[HOLD for payment Aug 18th] Sign up - User is not redirected to mobile app to set up password

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Create a new account via the mobile app.
2. Click on the email validation link
3. User is redirected to mWeb instead of app - Set up a password in mWeb
4. Navigate back to app.

Expected Result:

User should not have to set up the password twice when signing up. I would say there are 2 expected scenarios:

1. The user sets up the password in mWeb and then is redirected to the app. The user should be logged in automatically in the app.
2. The user is redirected to the app to set the password there. After setting the password the user is automatically logged in.

Actual Result:

User is redirected to mWeb to set the password and has to log in again in app.
This is working as expected in Android. User is given the option to choose mWeb or App.

Workaround:

User has to log in the app (again) after setting the password in mWeb.

Platform:

Where is this issue occurring?

• iOS

Version Number: 1.0.82-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Image.from.iOS.4.MP4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

---

From @muttmuure https://expensify.slack.com/archives/C01GTK53T8Q/p1627905084053000

New user sign up is broken. Images in 🧵

Sign up with email address.
Request magic sign in link.
Click magic sign in link (you’re dropped straight into the app in mobile web).
Navigate back to mobile app.
Still see the magic sign in screen.

[MelvinBot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[AndrewGable]

@muttmuure - Can you elaborate on how this used to work? It might help trace down this issue. I think it might be a deep link is broken, but I am not sure.

[dklymenk]

Hello, in case you decide to make this one external, I'm going to throw in a proposal:

Apparently, after latest migration from expensify.cash to new.expensify.com, the "Associated Domains" section on "Signing & Capabilities" project settings tab wasn't updated. Here is a screenshot:

I am fairly certain that removing the old associations and adding the new domain will fix the issue. The domains specified in AndroidManifest.xml look good to me, that's why the issue is iOS only.

[muttmuure]

Sorry @AndrewGable I can't be sure what the exact behavior was - I think it's number 1 in @isagoico's OP?

If @dklymenk's solution above looks correct would you be able to verify?

[dklymenk]

@muttmuure yes, I have a macbook and can verify the fix via simulator.

As for your concern about which behavior it is, I can do a quick check on android. IMO it is a pretty safe bet to assume that this behavior should be the same on both android and iOS.

[AndrewGable]

Thanks for checking into this @dklymenk - Please provide a complete solution for Android as well and we can configure the job in Upwork.

[MelvinBot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[dklymenk]

Please provide a complete solution for Android as well

It seems like you have misinterpreted my previous message. I meant that instead of trying to remember which of the behaviors, described in the original post, used to be implemented in the iOS app, we can take a look at android implementation and then make sure the iOS implementation matches the android one.

Anyway, I have checked on android and this is flow we have there:

2. The user is redirected to the app to set the password there. After setting the password the user is automatically logged in.

Even if you pick the web browser instead of the app on the "Choose app" screen, there is no navigation back to the app once you successfully submit the form. No prompts to open the app. Nothing to indicate that behaviour # 1 from the OP was ever implemented. There is nothing like that happening in the code for submit handler on that form too.

So I have applied the fix described above to the iOS build via xcode and confirmed that with the fix the behavior is 100% the same as on android.

Recap: My proposal for this issue is to add new.expensify.com to the list of "Associated Domains" on "Signing & Capabilities" project settings tab in xcode (see screenshot above). Also remove the old domains to match the android configuration in AndroidManifest.xml, This action translates into the following diff:

--- a/ios/ExpensifyCash/Chat.entitlements
+++ b/ios/ExpensifyCash/Chat.entitlements
@@ -9,6 +9,7 @@
-               <string>applinks:www.expensify.cash</string>
                <string>applinks:staging.expensify.cash</string>
-               <string>applinks:expensify.cash</string>
+               <string>applinks:new.expensify.com</string>
        </array>
 </dict>
 </plist>

Thanks.

[AndrewGable]

Sounds good, @Christinadobrzyn can you please hire @dklymenk? I look forward to reviewing the PR 👍

[Christinadobrzyn]

Posted in Upwork

Internal job post - https://www.upwork.com/ab/applicants/1422783368849924096/job-details
External job post - https://www.upwork.com/jobs/~01e5ed6013bc933fd8

Just checking that the price page in Upwork is correct for this job. I will hire dklymenk as soon as I get a buddy check here.

[parasharrajat]

Letting you all know that this issue is being covered from #4213.
Anyways it can still be fixed here separately, if you want.!
cc: @Christinadobrzyn

Edit:
Yeah, this issue is different. Sorry for the ping.

[dklymenk]

Hello, @Christinadobrzyn . I have submitted a proposal to the upwork post.

Thanks.

[Christinadobrzyn]

Thanks, @dklymenk! There seems to be a bug on the Upwork hire page, so I'm working with our team to resolve that and then I'll hire you in Upwork (hopefully tomorrow)! Thanks for your patience!

[elemanhillary-zz]

Hello, my proposal and my first solution would look at the scheme urls and if the app bundle really match with that on firebase console

[AndrewGable]

Thank you for the proposal @elemanhillary, but we have already selected a proposal and contributor to fix this issue.

[elemanhillary-zz]

okay thanks, the project is still open on upwork, maybe close it so that others don't apply just like how i did

[Christinadobrzyn]

Hi @dklymenk! Good news, the bug is fixed on the Upwork hire page and I was able to hire you for this job in Upwork. Thanks!

[dklymenk]

Hello, I have submitted a PR for this issue: #4418

Thanks.

[Christinadobrzyn]

Awesome! We'll hold of payment on August 11th!

[dklymenk]

Awesome! We'll hold of payment on August 11th!

Hello. I don't think it's merged, or have the rules changed or something?

[Christinadobrzyn]

Ah, thank you @dklymenk - you are correct, we're waiting for a merge for the PR. We'll hold off on payment until 7 days after the PR is merged.

[Christinadobrzyn]

PR has been merged for 7 days - paid @dklymenk in Upwork and closed job!